Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulnerability][acl] ACL is skipped for class instances as source objects in Object.assign() #333

Closed
t2ym opened this issue Feb 7, 2020 · 0 comments

Comments

@t2ym
Copy link
Owner

t2ym commented Feb 7, 2020

[vulnerability][acl] ACL is skipped for class instances as source objects in Object.assign()

Root Cause

Reproducible Code

window.Class = class Class {};
// This access must throw if acl.Class[S_PROTOTYPE][S_INSTANCE][S_ALL]: '---'
Object.assign({}, new Class());

Fix

  • Check constructors of source objects as well as the object themselves
t2ym added a commit that referenced this issue Feb 7, 2020
…Check constructors of Object.assign() source objects
t2ym added a commit that referenced this issue Feb 7, 2020
@t2ym t2ym closed this as completed in ffe5510 Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant