Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[demo][acl] customElements.define('dummy-element', Class) can bypass ACL for Class #211

Closed
t2ym opened this issue Jan 8, 2018 · 1 comment
Closed

[demo][acl] customElements.define('dummy-element', Class) can bypass ACL for Class #211

t2ym opened this issue Jan 8, 2018 · 1 comment

Comments

@t2ym
Copy link
Owner

t2ym commented Jan 8, 2018

[demo][acl] customElements.define('dummy-element', Class) can bypass ACL for Class

Root Cause

customElement.define() can overwrite ACL mapping for the constructor class

Example Reproducible Code

  customElements.define('html-element9', HTMLElement);
  HTMLElement.prototype.click = null; // bypass ACL for HTMLElement
@t2ym t2ym closed this as completed in fce8973 Jan 8, 2018
t2ym added a commit that referenced this issue Jan 8, 2018
@t2ym
0.0.211 with Fix #211 Avoid bypassing ACL by dummy custom elements
9f63576
@t2ym
Copy link
Owner Author

t2ym commented Jan 8, 2018

Note

  • Custom Element constructor classes must not be global objects after this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@t2ym