Add strict to tsconfig.json

Author: wooorm

lib/footer.js

@@ -40,10 +40,9 @@ export function footer(h) {
     const tail = content[content.length - 1]
 
     if (tail && tail.type === 'paragraph') {
-      // @ts-ignore it’s a paragraph, TypeScript…
       tail.children.push(backReference)
     } else {
-      // @ts-ignore Indeed, link directly added in block content.
+      // @ts-expect-error Indeed, link directly added in block content.
       content.push(backReference)
     }
 
@@ -64,10 +63,10 @@ export function footer(h) {
     'section',
     {className: ['footnotes'], role: 'doc-endnotes'},
     wrap(
-      [].concat(
+      [
         thematicBreak(h),
         list(h, {type: 'list', ordered: true, children: listItems})
-      ),
+      ],
       true
     )
   )

lib/handlers/html.js

@@ -12,6 +12,6 @@ import {u} from 'unist-builder'
  * @param {HTML} node
  */
 export function html(h, node) {
-  // @ts-ignore non-standard raw nodes.
+  // @ts-expect-error non-standard raw nodes.
   return h.dangerous ? h.augment(node, u('raw', node.value)) : null
 }

lib/handlers/list-item.js

@@ -56,11 +56,9 @@ export function listItem(h, node, parent) {
   }
 
   let index = -1
-  /** @type {Content} */
-  let child
 
   while (++index < result.length) {
-    child = result[index]
+    const child = result[index]
 
     // Add eols before nodes, except if this is a loose, first paragraph.
     if (
@@ -79,11 +77,10 @@ export function listItem(h, node, parent) {
     }
   }
 
+  const tail = result[result.length - 1]
+
   // Add a final eol.
-  if (
-    result.length > 0 &&
-    (loose || !('tagName' in child) || child.tagName !== 'p')
-  ) {
+  if (tail && (loose || !('tagName' in tail) || tail.tagName !== 'p')) {
     wrapped.push(u('text', '\n'))
   }
 
@@ -103,7 +100,7 @@ function listLoose(node) {
     loose = listItemLoose(children[index])
   }
 
-  return loose
+  return Boolean(loose)
 }
 
 /**

lib/handlers/list.js

@@ -1,5 +1,6 @@
 /**
  * @typedef {import('mdast').List} List
+ * @typedef {import('hast').Element} Element
  * @typedef {import('hast').Properties} Properties
  * @typedef {import('../index.js').Handler} Handler
  */
@@ -10,6 +11,7 @@ import {all} from '../traverse.js'
 /**
  * @type {Handler}
  * @param {List} node
+ * @returns {Element}
  */
 export function list(h, node) {
   /** @type {Properties} */
@@ -29,9 +31,9 @@ export function list(h, node) {
     if (
       item.type === 'element' &&
       item.tagName === 'li' &&
-      // @ts-ignore looks like properties.
+      // @ts-expect-error looks like properties.
       item.properties.className &&
-      // @ts-ignore looks like properties.
+      // @ts-expect-error looks like properties.
       item.properties.className.includes('task-list-item')
     ) {
       props.className = ['contains-task-list']

lib/handlers/root.js

@@ -12,6 +12,6 @@ import {wrap} from '../wrap.js'
  * @param {Root} node
  */
 export function root(h, node) {
-  // @ts-ignore top-level is a root.
+  // @ts-expect-error top-level is a root.
   return h.augment(node, u('root', wrap(all(h, node))))
 }

lib/handlers/thematic-break.js

@@ -1,11 +1,13 @@
 /**
  * @typedef {import('mdast').ThematicBreak} ThematicBreak
+ * @typedef {import('hast').Element} Element
  * @typedef {import('../index.js').Handler} Handler
  */
 
 /**
  * @type {Handler}
  * @param {ThematicBreak} [node]
+ * @returns {Element}
  */
 export function thematicBreak(h, node) {
   return h(node, 'hr')

lib/index.js

@@ -24,7 +24,7 @@
  *
  * @callback Handler
  * @param {H} h Handle context
- * @param {Node} node mdast node to handle
+ * @param {any} node mdast node to handle
  * @param {Parent|null} parent Parent of `node`
  * @returns {Content|Array.<Content>|null|undefined} hast node
  *
@@ -97,7 +97,7 @@ function factory(tree, options) {
 
   visit(tree, 'footnoteDefinition', onfootnotedefinition)
 
-  // @ts-ignore Hush, it’s fine!
+  // @ts-expect-error Hush, it’s fine!
   return h
 
   /**
@@ -135,7 +135,6 @@ function factory(tree, options) {
     }
 
     if (left) {
-      // @ts-ignore looks like a node vs. position.
       const ctx = 'type' in left ? left : {position: left}
 
       if (!generated(ctx)) {
@@ -157,7 +156,7 @@ function factory(tree, options) {
       props = {}
     }
 
-    // @ts-ignore augmenting an element yields an element.
+    // @ts-expect-error augmenting an element yields an element.
     return augment(node, {
       type: 'element',
       tagName,
@@ -193,7 +192,7 @@ export function toHast(tree, options) {
   const foot = footer(h)
 
   if (foot) {
-    // @ts-ignore If there’s a footer, there were definitions, meaning block
+    // @ts-expect-error If there’s a footer, there were definitions, meaning block
     // content.
     // So assume `node` is a parent node.
     node.children.push(u('text', '\n'), foot)

lib/traverse.js

@@ -15,6 +15,7 @@ const own = {}.hasOwnProperty
 /**
  * Transform an unknown node.
  * @type {Handler}
+ * @param {Node} node
  */
 function unknown(h, node) {
   if (text(node)) {
@@ -26,6 +27,7 @@ function unknown(h, node) {
 
 /**
  * @type {Handler}
+ * @param {Node} node
  */
 export function one(h, node, parent) {
   const type = node && node.type
@@ -69,9 +71,10 @@ function text(node) {
 
 /**
  * @type {Handler}
+ * @param {unknown} node
  */
 function returnNode(h, node) {
-  // @ts-ignore pass through any unknown node.
+  // @ts-expect-error pass through any unknown node.
   return node.children ? {...node, children: all(h, node)} : node
 }
 
@@ -81,14 +84,14 @@ function returnNode(h, node) {
  */
 export function all(h, parent) {
   /** @type {Array.<Node>} */
-  // @ts-ignore looks like a parent.
+  // @ts-expect-error looks like a parent.
   const nodes = parent.children || []
   /** @type {Array.<Content>} */
   const values = []
   let index = -1
 
   while (++index < nodes.length) {
-    // @ts-ignore looks like a parent.
+    // @ts-expect-error looks like a parent.
     const result = one(h, nodes[index], parent)
 
     if (result) {

package.json

@@ -88,6 +88,10 @@
   "typeCoverage": {
     "atLeast": 100,
     "detail": true,
-    "strict": true
+    "strict": true,
+    "#": "needed `any`s",
+    "ignoreFiles": [
+      "lib/index.d.ts"
+    ]
   }
 }

test/core.js

@@ -5,7 +5,7 @@ import {toHast} from '../index.js'
 test('toHast()', (t) => {
   t.throws(
     () => {
-      // @ts-ignore runtime.
+      // @ts-expect-error runtime.
       toHast(u('bar', [true]))
     },
     /Expected node, got `true`/,
@@ -79,6 +79,7 @@ test('toHast()', (t) => {
         'tango'
       )
     ),
+    // @ts-expect-error: `null`s are fine-ish (and given by `unist-util-position`)
     u(
       'element',
       {

test/handlers-option.js

@@ -50,8 +50,8 @@ test('handlers option', (t) => {
 
   t.deepEqual(
     toHast(customMdast, {
-      // @ts-ignore `hast` expected, but this returns unknown mdast nodes.
-      unknownHandler(_, node) {
+      // @ts-expect-error `hast` expected, but this returns unknown mdast nodes.
+      unknownHandler(_, /** @type {object} */ node) {
         return node
       }
     }),

tsconfig.json

@@ -10,6 +10,7 @@
     "declaration": true,
     "emitDeclarationOnly": true,
     "allowSyntheticDefaultImports": true,
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "strict": true
   }
 }