More sorting and list field fixes #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
+ Coverage 80.59% 80.64% +0.05%
==========================================
Files 24 24
Lines 2818 2826 +8
==========================================
+ Hits 2271 2279 +8
Misses 477 477
Partials 70 70
Continue to review full report in Codecov by Sentry.
|
- Sorting by Profile was busted because we were loading ProfileFormat
after sorting
- Fix bug where we did not detect invalid field names for `list`
- Generally clean up logic/code
- Don't do SSO workflow for CSV since we don't report SSO Token expire
time in CSV output
- ListFields now deprecates AccountIdStr for AccountIdPad
Fixes: #503, #506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
listFixes: #503, #506