Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings for missing access to accounts present in config #980

Closed
Moulick opened this issue Jul 12, 2024 · 4 comments · Fixed by #981
Closed

Warnings for missing access to accounts present in config #980

Moulick opened this issue Jul 12, 2024 · 4 comments · Fixed by #981
Labels
enhancement New feature or request
Milestone

Comments

@Moulick
Copy link

Moulick commented Jul 12, 2024

Output of aws-sso version:

Example output:
AWS SSO CLI Version 1.17.0 -- Copyright 2021-2024 Aaron Turner
Homebrew (1.17.0) built at 2024-07-10T21:26:18Z

Describe the bug:
Just updated to 1.17 and aws-sso-cli has started warning about missing access for accounts in the config file. My colleagues and I have a shared aws-sso-cli config file and not everyone has access to all the accounts in the config file. We were currently relying on the fact that aws-sso-cli does not give any error or warning if account access is missing and will only configure the ones that a person has access to. aws-sso-cli now has started warning which is annoying.

To Reproduce:

  1. Add some accounts to ~/.aws-sso/config.yaml that you don't have access
  2. Run aws-sso config-profiles and see warning printed for missing access

Expected behavior:
Warning to not be printed if access is missing.

Desktop (please complete the following information):

  • OS: MacOs
  • Version: 14.5 (23F79)
@Moulick Moulick added the bug Something isn't working label Jul 12, 2024
@Moulick Moulick changed the title Warnings access to accounts present in config file missing Warnings for missing access to accounts present in config Jul 12, 2024
@synfinatic synfinatic added enhancement New feature or request and removed bug Something isn't working labels Jul 12, 2024
@synfinatic
Copy link
Owner

I can see about moving this to debug or something like that. I'm curious though, what attributes are you providing in your shared config for these roles that makes it necessary to define them in the file?

@Moulick
Copy link
Author

Moulick commented Jul 12, 2024

Moving to debug should pretty much solve this problem, I think.

Main reason was for having a shared config are.

  1. Standardizing the ProfileFormat,
  2. Providing SSOConfig.Default.Accounts.Name for some aws accounts where the actual aws name is stoopid and cannot be changed because reasons.
  3. Different regions for different accounts. Make it easier to just run export AWS_PROFILE=<xyz> and the user get the right region for that account.
  4. Add tags because why not, even though never really used.
  5. Everyone gets the script for Unable to use in GitHub Codespaces #816
  6. Quick onboarding for people with good defaults

@Moulick
Copy link
Author

Moulick commented Nov 18, 2024

@synfinatic I see this is slated for the 2.0.0 release, is it possible to release this minor change as a patch version in v1.x.x series please? Or if the v2.0.0 release is close then nevermind :)

Nevermind, I switched to using brew install aws-sso-cli --head which clones the repo and installed the head commit ;)

@synfinatic
Copy link
Owner

Beta5 should be out soonish. I honestly wouldn't recommend staying on head for long periods of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants