Wincred not support more than 2600 bytes

[monwolf]

Hi,

I'm opening this issue because¡ I tried to update from v to v1.7.4 and I saw windows support is broken due to a limitation on the wincred manager. When I try to run the newer version I'm getting the error:

level=warning msg="Unable to cache role credentials in secure store" func=main.GetRoleCredentials file="/Users/aturner/go/src/github.com/synfinatic/aws-sso-cli/cmd/main.go:280" error="El fragmento ha recibido datos incorrectos."

After searching a bit on the Internet I saw the issue:

danieljoos/wincred#18

That is related to this error message, so I debugged the application and saw the JSON we are trying to save has around 3.7K bytes.

To Reproduce:
aws-sso exec -A "my-account" --role=AdministratorAccess aws eks get-token --cluster-name my-cluster

Expected behavior:

I expect all work fine :)

Screenshots:

Error:

Cause:

Desktop (please complete the following information):

• OS: Windows
• Version 10

Additional context:
danieljoos/wincred#18

Contents of ~/.aws-sso/config.yaml:

SSOConfig:
    xxxx-sso:
        SSORegion: us-east-1
        StartUrl: https://xxxxx.awsapps.com/start
DefaultSSO: xxxx-sso
LogLevel: warn
LogLines: true
UrlAction: open
SecureStore: wincred 

[monwolf]

@synfinatic I think I could split it into chunks of 2K save it and then reconstruct it for recovery. What do you think about this?

Your patch is a little bit "tricky", it only "works" if Windows is installed with the ENG locale xD

	// Work around bogus errors wincred storage issue.  Sadly doesn't seem
	// like we can tell if are using windcred, so just key off of the OS
	// https://github.com/99designs/keyring/issues/99
	if err != nil && runtime.GOOS == "windows" && err.Error() == "The stub received bad data." {
		return nil
	}
	return err

[synfinatic]

Oh, is that what is going on... that's just lovely. :-/

In theory, I would be open to looking at a patch which breaks the JSON blob into 2K chunks... I have a few concerns, but haven't thought about it enough yet to know if they are legit or not- mostly just about keeping the code clean and maintainable.

If you do submit a patch, please include unit tests.

[monwolf]

With this patch I've been able to run it on windows without problems