Fix clippy issues.

Author: daemontus

src/_aeon_parser/_from_string_for_fn_update_temp.rs

@@ -114,7 +114,7 @@ fn parse_update_function(data: &[Token]) -> Result<Box<FnUpdateTemp>, String> {
 
 /// **(internal)** Utility method to find first occurrence of a specific token in the token tree.
 fn index_of_first(data: &[Token], token: Token) -> Option<usize> {
-    return data.iter().position(|t| *t == token);
+    data.iter().position(|t| *t == token)
 }
 
 /// **(internal)** Recursive parsing step 1: extract `<=>` operators.

src/_impl_extended_boolean.rs

@@ -39,7 +39,6 @@ impl Display for ExtendedBoolean {
 
 /// Implements a "set-like" ordering for extended Booleans. "Any" is greater than constant values
 /// (since it covers both values), while constant values are incomparable between each other.
-
 impl PartialOrd for ExtendedBoolean {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
         match (self, other) {

src/fixed_points/symbolic_iterator.rs

@@ -35,7 +35,7 @@ pub struct SymbolicIterator<'a> {
     inner: RawSymbolicIterator<'a>,
 }
 
-impl<'a> Iterator for RawSymbolicIterator<'a> {
+impl Iterator for RawSymbolicIterator<'_> {
     type Item = Bdd;
 
     fn next(&mut self) -> Option<Self::Item> {
@@ -162,7 +162,7 @@ impl<'a> Iterator for RawSymbolicIterator<'a> {
     }
 }
 
-impl<'a> RawSymbolicIterator<'a> {
+impl RawSymbolicIterator<'_> {
     /// Try to split this iterator into two independent disjoint iterators, assuming there are
     /// enough forks to permit such operation.
     pub fn try_split(&mut self) -> Option<Self> {
@@ -180,7 +180,7 @@ impl<'a> RawSymbolicIterator<'a> {
     }
 }
 
-impl<'a> Iterator for SymbolicIterator<'a> {
+impl Iterator for SymbolicIterator<'_> {
     type Item = GraphColoredVertices;
 
     fn next(&mut self) -> Option<Self::Item> {

src/sbml/import/_convert_mathml_to_fn_update.rs

@@ -139,7 +139,7 @@ pub fn sbml_transition_to_update_function(
         panic!("Converting an unspecified transition to FnUpdate.");
     }
 
-    return if transition.function_terms.is_empty() {
+    if transition.function_terms.is_empty() {
         if transition.default_term.as_ref().unwrap().result_level == 0 {
             Ok(FnUpdate::Const(false))
         } else if transition.default_term.as_ref().unwrap().result_level == 1 {
@@ -163,7 +163,7 @@ pub fn sbml_transition_to_update_function(
         } else {
             math_to_update(term.math.as_ref().unwrap(), network, transition, id_to_var)
         }
-    };
+    }
 }
 
 /// **(internal)** Utility function for turning comparisons into valid `FnUpdate` functions.

src/symbolic_async_graph/_impl_symbolic_async_graph.rs

@@ -1045,7 +1045,7 @@ impl SymbolicAsyncGraph {
         // Ideally, all parameters should be used, but just in case they are not, we should also
         // go through those that are not used:
         let mut unused_parameters: HashSet<ParameterId> = HashSet::from_iter(bn.parameters());
-        for (_, v) in &clusters {
+        for v in clusters.values() {
             for p in v {
                 if unused_parameters.contains(p) {
                     unused_parameters.remove(p);
@@ -1092,9 +1092,7 @@ impl SymbolicAsyncGraph {
                     })
                     .collect::<Vec<_>>();
 
-                if !unique_interpretations.contains_key(&key) {
-                    unique_interpretations.insert(key, valuation);
-                }
+                unique_interpretations.entry(key).or_insert(valuation);
             }
             println!("Unique: {:?}", unique_interpretations.len());
             for (k, v) in unique_interpretations.iter() {

src/symbolic_async_graph/_impl_symbolic_context.rs

@@ -579,7 +579,7 @@ impl SymbolicContext {
 
     /// **(internal)** Utility method for converting `FnUpdate` arguments to `Bdd` arguments.
     fn prepare_args(&self, args: &[FnUpdate]) -> Vec<Bdd> {
-        return args.iter().map(|v| self.mk_fn_update_true(v)).collect();
+        args.iter().map(|v| self.mk_fn_update_true(v)).collect()
     }
 
     /// This is similar to [BddVariableSet::transfer_from], but applied at the level of

src/symbolic_async_graph/projected_iteration.rs

@@ -130,7 +130,7 @@ fn restrict_valuation(valuation: BddValuation, retain: &[BddVariable]) -> BddPar
     partial
 }
 
-impl<'a> Iterator for RawSymbolicIterator<'a> {
+impl Iterator for RawSymbolicIterator<'_> {
     type Item = BddPartialValuation;
 
     fn next(&mut self) -> Option<Self::Item> {
@@ -188,7 +188,7 @@ impl StateProjection {
     }
 }
 
-impl<'a> Iterator for StateProjectionIterator<'a> {
+impl Iterator for StateProjectionIterator<'_> {
     type Item = Vec<(VariableId, bool)>;
 
     fn next(&mut self) -> Option<Self::Item> {
@@ -247,7 +247,7 @@ impl<'a> FnUpdateProjection<'a> {
     }
 }
 
-impl<'a, 'b> Iterator for FnUpdateProjectionIterator<'a, 'b> {
+impl Iterator for FnUpdateProjectionIterator<'_, '_> {
     type Item = Vec<(VariableId, FnUpdate)>;
 
     fn next(&mut self) -> Option<Self::Item> {
@@ -313,7 +313,7 @@ impl<'a> MixedProjection<'a> {
     }
 }
 
-impl<'a, 'b> Iterator for MixedProjectionIterator<'a, 'b> {
+impl Iterator for MixedProjectionIterator<'_, '_> {
     type Item = (Vec<(VariableId, bool)>, Vec<(VariableId, FnUpdate)>);
 
     fn next(&mut self) -> Option<Self::Item> {