Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling .contextMenu('hide') throws an error #351

Closed
arashdalir opened this issue Feb 16, 2016 · 7 comments
Closed

Calling .contextMenu('hide') throws an error #351

arashdalir opened this issue Feb 16, 2016 · 7 comments
Labels

Comments

@arashdalir
Copy link
Contributor

Hi again!

Apparently manually firing the .contextMenu('hide') function to manually hide the menu causes the following line to trigger an exception. The root.$menu is empty when function is triggered manually (i.e. JS function $menu.contextMenu('hide')). When tracing the js-code, the value is filled if event is triggered when user clicks away, but not when js fires the function.

line:636: root.$menu.trigger('contextmenu:hide');
result: Uncaught TypeError: Cannot read property 'trigger' of undefined

@bbrala
Copy link
Member

bbrala commented Feb 18, 2016

Good catch, kind of weird. I'll try to make some time this week to go through this issue.

@arashdalir
Copy link
Contributor Author

Well, I'm (ab)using the menu intensively and therefore find some things, which aren't seen easily! :D
I'm not sure if I can also ask for a feature-implementation, I should do it in a separate issue, right?

@bbrala
Copy link
Member

bbrala commented Feb 18, 2016

The easiest way to get a feature in is to open a issue to discuss and then make a pull request. But i do try to create features that i feel are good additions. The problem is my time is sometimes a little limited :)

@arashdalir
Copy link
Contributor Author

Could you please inform me if this feature is already implemented or not?
Is there a way to see if the contextmenu ist open at any point of time? If it's not implemented, I'll make an issue (feature request) out of it.

Thanks a lot

@bbrala
Copy link
Member

bbrala commented Feb 18, 2016

I searched the repos and found the clicked element gets a classname: context-menu-active, see #92

@arashdalir
Copy link
Contributor Author

Thanks a lot :) You are right, I could have checked that.
Sorry and Thanks again

@bbrala bbrala added the Bug label May 24, 2016
@bbrala
Copy link
Member

bbrala commented Aug 26, 2016

Seems fixed see #352

@bbrala bbrala closed this as completed Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants