fix: account for mustache inside mustache (#1091)

sveltejs · Feb 26, 2025 · 83da078 · 83da078
1 parent 28200aa
commit 83da078
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/better-rice-join.md b/.changeset/better-rice-join.md
@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': patch
+---
+
+fix: Don't remove mustache'd string literals if they contain curly braces
diff --git a/packages/eslint-plugin-svelte/src/rules/no-useless-mustaches.ts b/packages/eslint-plugin-svelte/src/rules/no-useless-mustaches.ts
@@ -85,6 +85,10 @@ export default createRule('no-useless-mustaches', {
 				return;
 			}
 
+			if (rawValue.includes('{')) {
+				return;
+			}
+
 			let hasEscape = false;
 			if (rawValue !== strValue) {
 				// check escapes

diff --git a/...t-plugin-svelte/tests/fixtures/rules/no-useless-mustaches/valid/valid-test01-input.svelte b/...t-plugin-svelte/tests/fixtures/rules/no-useless-mustaches/valid/valid-test01-input.svelte
@@ -8,5 +8,6 @@ foo 'foo'
 {1}
 {null}
 {`foo${foo}`}
+{'{foo'}
 
 <div data-text="foo 'foo' {foo} {'foo' || 'bar'} {1} {null}" />