Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting an adapter should remove the comment about adapter-auto #430

Closed
mquandalle opened this issue Jan 31, 2025 · 2 comments · Fixed by #436
Closed

Setting an adapter should remove the comment about adapter-auto #430

mquandalle opened this issue Jan 31, 2025 · 2 comments · Fixed by #436
Labels
enhancement New feature or request help wanted Extra attention is needed pkg:add sv add

Comments

@mquandalle
Copy link

mquandalle commented Jan 31, 2025

When setting an adapter during sv create, the file svelte.config.js is modified, but the following comment about adapter-auto is left untouched:

	kit: {
		// adapter-auto only supports some environments, see https://svelte.dev/docs/kit/adapter-auto for a list.
		// If your environment is not supported, or you settled on a specific environment, switch out the adapter.
		// See https://svelte.dev/docs/kit/adapters for more information about adapters.
		adapter: adapter()
	}

I think this comment should be removed in the https://github.com/sveltejs/cli/blob/main/packages/addons/sveltekit-adapter/index.ts script.

(Or maybe the code logic could be inverted, and this comment be inserted only if adapter-auto is selected on creation)

@manuel3108
Copy link
Member

(Or maybe the code logic could be inverted, and this comment be inserted only if adapter-auto is selected on creation)

This won't work since you are able to finish the setup without running the sveltekit-addon at all.

But other than that, this totally makes sense!

@manuel3108 manuel3108 added enhancement New feature or request help wanted Extra attention is needed pkg:add sv add labels Jan 31, 2025
@mquandalle
Copy link
Author

mquandalle commented Feb 2, 2025

I tried to do it but it's not clear to me how this should be implemented and tested.

ranjan-purbey added a commit to ranjan-purbey/svelte-cli that referenced this issue Feb 4, 2025
...once a specific sveltekit adapter is chosen

Fixes sveltejs#430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed pkg:add sv add
Projects
None yet
2 participants