Skip to content

Commit be6fe65

Browse files
committed
fixed f- and v- tests
1 parent e4ad635 commit be6fe65

File tree

3 files changed

+13
-17
lines changed

3 files changed

+13
-17
lines changed

functionalTests/preview/simulator.ts

+1
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ test("Simulator popups", async (t) => {
5050
.expect(dropdownPopupContainer.visible).ok()
5151
.expect(dropdownPopup.classNames).contains(overlayPopup)
5252
.expect(dropdownPopup.classNames).contains(tabletPopup)
53+
.click(Selector(".sv-popup--dropdown-overlay"), { offsetY: 10 })
5354

5455
.click(getBarItemByTitle("Select device type"))
5556
.click(getListItemByText("iPhone 15"))

packages/survey-creator-core/src/components/popup.scss

+11-16
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@
3636
}
3737

3838
&.sv-popup--dropdown-overlay .sv-popup__scrolling-content {
39-
height: auto
39+
height: auto;
4040
}
41-
42-
&.sv-popup--overlay.sv-popup--tablet > .sv-popup__container {
41+
42+
&.sv-popup--overlay.sv-popup--tablet {
4343
background-color: var(--ctr-popup-haze-background-color, $background-semitransparent);
4444
}
45-
&.sv-popup--overlay .sv-popup__container {
45+
&.sv-popup--overlay {
4646
// background-color: var(--ctr-popup-menu-background-color, $background);
4747
background-color: var(--ctr-popup-haze-background-color, $background-semitransparent);
4848
}
@@ -68,18 +68,13 @@
6868
.sv-popup__container {
6969
background-color: transparent;
7070
border-radius: var(--ctr-popup-menu-corner-radius, calcSize(0.5));
71-
box-shadow:
72-
var(--ctr-popup-menu-shadow-1-offset-x, 0px)
73-
var(--ctr-popup-menu-shadow-1-offset-y, 2px)
74-
var(--ctr-popup-menu-shadow-1-blur, 6px)
75-
var(--ctr-popup-menu-shadow-1-spread, 0px)
76-
var(--ctr-popup-menu-shadow-1-color, rgba(0, 0, 0, 0.1)),
77-
78-
var(--ctr-popup-menu-shadow-2-offset-x, 0px)
79-
var(--ctr-popup-menu-shadow-2-offset-y, 8px)
80-
var(--ctr-popup-menu-shadow-2-blur, 16px)
81-
var(--ctr-popup-menu-shadow-2-spread, 0px)
82-
var(--ctr-popup-menu-shadow-2-color, rgba(0, 0, 0, 0.1));
71+
box-shadow:
72+
var(--ctr-popup-menu-shadow-1-offset-x, 0px) var(--ctr-popup-menu-shadow-1-offset-y, 2px)
73+
var(--ctr-popup-menu-shadow-1-blur, 6px) var(--ctr-popup-menu-shadow-1-spread, 0px)
74+
var(--ctr-popup-menu-shadow-1-color, rgba(0, 0, 0, 0.1)),
75+
var(--ctr-popup-menu-shadow-2-offset-x, 0px) var(--ctr-popup-menu-shadow-2-offset-y, 8px)
76+
var(--ctr-popup-menu-shadow-2-blur, 16px) var(--ctr-popup-menu-shadow-2-spread, 0px)
77+
var(--ctr-popup-menu-shadow-2-color, rgba(0, 0, 0, 0.1));
8378
}
8479

8580
.sv-popup__body-header {

visualRegressionTests/tests/designer/pg-editors.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -850,7 +850,7 @@ test("popup overlay in property grid", async (t) => {
850850
.click(getQuestionBarItemByTitle("Open settings"))
851851
.click(Selector(".spg-dropdown[aria-label='Input type']"));
852852

853-
await takeElementScreenshot("pg-overlay-popup.png", getVisibleElement(".sv-popup .sv-popup__container"), t, comparer);
853+
await takeElementScreenshot("pg-overlay-popup.png", getVisibleElement(".sv-popup"), t, comparer);
854854
});
855855
});
856856
fixture`${title}`.page`${url}`.beforeEach(async (t) => { });

0 commit comments

Comments
 (0)