Fix: "set" property editor doesn't support ajax request for getting choices #720

Author: andrewtelnov

src/propertyEditors/propertyDefaultValueEditor.ts

@@ -261,7 +261,7 @@ export class SurveyPropertySetEditor extends SurveyPropertyDefaultValueEditor {
     var hasTagbox = !!Survey.Serializer.findClass("tagbox");
     question.hasSelectAll = !hasTagbox;
     if (!!this.property) {
-      question.choices = this.property.getChoices(this.object);
+      question.choices = this.getPropertyChoices();
     }
     var json = SurveyPropertyDefaultValueEditor.createJsonFromQuestion(
       question,
@@ -272,6 +272,18 @@ export class SurveyPropertySetEditor extends SurveyPropertyDefaultValueEditor {
     }
     return json;
   }
+  private setChoices(choices: Array<any>) {
+    var survey = this.koSurvey();
+    if (!survey || survey.getAllQuestions().length > 1) return;
+    survey.getAllQuestions()[0].choices = choices;
+  }
+  private getPropertyChoices(): Array<any> {
+    if (!this.property) return [];
+    var self = this;
+    return this.property.getChoices(this.object, function(choices: any) {
+      self.setChoices(choices);
+    });
+  }
 }
 
 SurveyPropertyEditorFactory.registerEditor("value", function(

src/propertyEditors/propertyEditorFactory.ts

@@ -221,7 +221,7 @@ export class SurveyDropdownPropertyEditor extends SurveyPropertyEditorBase {
   protected getPropertyChoices(): Array<any> {
     if (!this.property) return [];
     var self = this;
-    return (<any>this.property.getChoices)(this.object, function(choices: any) {
+    return this.property.getChoices(this.object, function(choices: any) {
       self.setChoices(choices);
     });
   }

tests/propertyEditors/propertyEditorsTests.ts

@@ -37,7 +37,10 @@ import {
   editorLocalization
 } from "../../src/editorLocalization";
 import { SurveyPropertyConditionEditor } from "../../src/propertyEditors/propertyConditionEditor";
-import { SurveyPropertyDefaultValueEditor } from "../../src/propertyEditors/propertyDefaultValueEditor";
+import {
+  SurveyPropertyDefaultValueEditor,
+  SurveyPropertySetEditor
+} from "../../src/propertyEditors/propertyDefaultValueEditor";
 import { SurveyPropertyCellsEditor } from "../../src/propertyEditors/propertyCellsEditor";
 
 export default QUnit.module("PropertyEditorsTests");
@@ -1490,6 +1493,48 @@ QUnit.test("Triggers property editor and setvalue trigger", function(assert) {
   );
 });
 
+QUnit.test("'set' property editor", function(assert) {
+  Survey.Serializer.addProperty("survey", {
+    name: "region:set",
+    choices: ["Africa", "Americas", "Asia", "Europe", "Oceania"]
+  });
+  var survey = createSurvey();
+  var setValueEditor = new SurveyPropertySetEditor(
+    Survey.Serializer.findProperty("survey", "region")
+  );
+  setValueEditor.object = survey;
+  setValueEditor.beforeShow();
+  var question = setValueEditor.koSurvey().getAllQuestions()[0];
+  assert.deepEqual(question.choices.length, 5, "There are 5 choices");
+  Survey.Serializer.removeProperty("survey", "region");
+});
+
+QUnit.test("'set' property editor, get choices on callback, Bug#720", function(
+  assert
+) {
+  var choices = ["Africa", "Americas", "Asia", "Europe", "Oceania"];
+  var callback = null;
+  Survey.Serializer.addProperty("survey", {
+    name: "region:set",
+    choices: function(obj, choicesCallback) {
+      callback = choicesCallback;
+      return [];
+    }
+  });
+  var survey = createSurvey();
+  var setValueEditor = new SurveyPropertySetEditor(
+    Survey.Serializer.findProperty("survey", "region")
+  );
+  setValueEditor.object = survey;
+  setValueEditor.beforeShow();
+  var question = setValueEditor.koSurvey().getAllQuestions()[0];
+  assert.deepEqual(question.choices.length, 0, "There is no choices yet");
+  callback(choices);
+  question = setValueEditor.koSurvey().getAllQuestions()[0];
+  assert.deepEqual(question.choices.length, 5, "There are 5 choices now");
+  Survey.Serializer.removeProperty("survey", "region");
+});
+
 QUnit.test("Validators property editor", function(assert) {
   var survey = createSurvey();
   var validator = new Survey.NumericValidator(10, 100);