#6694 The subitem dropdown throws an exception on selecting an item when the creator.toolbox.showSubitems option is disabled (#6712)

* #6694 The subitem dropdown throws an exception on selecting an item when the `creator.toolbox.showSubitems` option is disabled
Fixes #6694

* #6694 - fixed unit tests

Author: novikov82

packages/survey-creator-core/src/components/question.ts

@@ -557,6 +557,7 @@ export class QuestionAdornerViewModel extends SurveyElementAdornerBase {
       element.closest(".svc-question__drag-area") && !element.closest(".svc-question__top-actions") ||
       element.closest(".sd-element__header") && !element.closest(".svc-string-editor");
   }
+
   protected updateQuestionTypeOrSubtypeListModel(listModel: ListModel, subtypeOnly: boolean) {
     const availableItems = this.getConvertToTypes();
     const defaultJsons = this.buildDefaultJsonMap(availableItems);
@@ -565,25 +566,32 @@ export class QuestionAdornerViewModel extends SurveyElementAdornerBase {
     let selectedAction: IAction;
     let selectedSubaction: IAction = undefined;
     let selectedSubactions = undefined;
+
+    const toolboxItemToAction = (item, needSeparator = false) => {
+      return this.creator.createIActionBarItemByClass(item, needSeparator, (questionType, json) => { this.convertQuestion(questionType, json, defaultJsons); });
+    };
+
     availableItems.forEach((item: QuestionToolboxItem) => {
       const needSeparator = lastItem && item.category != lastItem.category;
-      const action = this.creator.createIActionBarItemByClass(item, needSeparator, (questionType, json) => { this.convertQuestion(questionType, json, defaultJsons); });
+      const action = toolboxItemToAction(item, needSeparator);
       if (this.toolboxItemIsCorresponded(item, !!selectedAction)) {
         selectedAction = action;
-        selectedSubactions = item.items;
+        if (item.items) {
+          selectedSubactions = item.items.map(subitem => toolboxItemToAction(subitem));
+        }
       }
       if (item.items?.length > 0 && this.creator.toolbox.showSubitems) {
         const subactions = [];
         let selectedSubactionLocal: IAction = undefined;
         let allChildsAreCompatibleToParent = false;
         item.items.forEach(subitem => {
-          const subaction = this.creator.createIActionBarItemByClass(subitem, false, (questionType, json) => { this.convertQuestion(questionType, json, defaultJsons); });
+          const subaction = toolboxItemToAction(subitem,);
           if (this.toolboxItemIsCorresponded(subitem, !!selectedAction)) selectedSubactionLocal = subitem;
           if (this.jsonsAreCompatible(item.json, subitem.json)) allChildsAreCompatibleToParent = true;
           subactions.push(subaction);
         });
         if (!allChildsAreCompatibleToParent && subactions.length > 0) {
-          const defaultSubaction = this.creator.createIActionBarItemByClass(item, false, (questionType, json) => { this.convertQuestion(questionType, json, defaultJsons); });
+          const defaultSubaction = toolboxItemToAction(item);
           defaultSubaction.id = action.id + "-default";
           defaultSubaction.iconName = undefined;
           defaultSubaction.markerIconName = undefined;

packages/survey-creator-core/tests/question-adorner.tests.ts

@@ -335,6 +335,13 @@ test("Check question converter no subitems", (): any => {
   const list = popup.contentComponentData.model;
   expect((list.getActionById("text").items || []).length).toBe(0);
 
+  const convertInputType = questionAdorner.actionContainer.getActionById("convertInputType");
+  const popupInputType = convertInputType.popupModel;
+  const popupInputTypeViewModel = new PopupDropdownViewModel(popupInputType); // need for popupModel.onShow
+  popupInputType.show();
+  const listInputType = popupInputType.contentComponentData.model;
+  expect(listInputType.actions.every(a => !(a instanceof QuestionToolboxItem))).toBeTruthy();
+
   surveySettings.animationEnabled = true;
 });