Choices Batch Editor treats the 0 numeric value as a nullish value and displays an empty string fix #6716 (#6719)

Author: andrewtelnov

packages/survey-creator-core/src/property-grid/fast-entry.ts

@@ -1,4 +1,4 @@
-import { ItemValue, QuestionCommentModel, QuestionTextBase, Serializer, Base } from "survey-core";
+import { ItemValue, QuestionCommentModel, QuestionTextBase, Serializer, Base, Helpers } from "survey-core";
 import { PropertyEditorSetupValue } from "./index";
 import { ISurveyCreatorOptions } from "../creator-settings";
 import { editorLocalization } from "../editorLocalization";
@@ -154,13 +154,14 @@ export class FastEntryEditorBase extends PropertyEditorSetupValue {
   protected collectNames(item, type: string, separatorCounter: number): string {
     let text: string = "";
     this.names.forEach((name) => {
+      let str = undefined;
       if (type === "itemvalues") {
         if (name == "value") return;
-        var str = name == "text" ? item.pureText : item[name];
+        str = name == "text" ? item.pureText : item[name];
       } else {
-        var str = item[name];
+        str = item[name];
       }
-      if (!!str) {
+      if (!Helpers.isValueEmpty(str)) {
         for (var i = 0; i < separatorCounter; i++) {
           text += ItemValue.Separator;
         }

packages/survey-creator-core/tests/property-grid/fast-entry.test.ts

@@ -139,3 +139,24 @@ test("Do not re-create with the same item.value", () => {
   expect(choices[5].value).toEqual("item8");
   expect(choices[5].getPropertyValue("#id")).toBeUndefined();
 });
+test("Work correctly with 0 number, Bug#6716", () => {
+  Serializer.addProperty("itemvalue", { name: "score:number" });
+  const originalElement = new QuestionRadiogroupModel("originalElement");
+  originalElement.choices = ["item1", "item2", "item2"];
+  const choices = originalElement.choices;
+  choices[0].score = 0;
+  choices[1].score = 1;
+  choices[2].score = 0;
+  const fastEntryEditor = new FastEntryEditor(choices, new EmptySurveyCreatorOptions(), undefined, ["value", "text", "score"]);
+  expect(fastEntryEditor.comment.value).toEqual("item1||0\nitem2||1\nitem2||0");
+  fastEntryEditor.comment.value = "item1||1\nitem2||0\nitem3||3";
+  fastEntryEditor.apply();
+  expect(originalElement.choices).toHaveLength(3);
+  expect(choices[0].value).toEqual("item1");
+  expect(choices[0].score).toBe("1");
+  expect(choices[1].value).toEqual("item2");
+  expect(choices[1].score).toBe("0");
+  expect(choices[2].value).toEqual("item3");
+  expect(choices[2].score).toBe("3");
+  Serializer.removeProperty("itemvalue", "score");
+});