Update sdk to 14 and related fixes #3444

davidyuk · 2024-12-26T13:33:59Z

This PR is supported by the Æternity Foundation

https://github.com/aeternity/aepp-sdk-js/blob/develop/docs/guides/migration/14.md

found issues #3463 aeternity/aepp-sdk-js#2046

github-actions · 2024-12-26T13:42:40Z

Deployed to feature-update-sdk.wallet.z52da5wt.xyz, artifacts

davidyuk · 2024-12-26T13:37:46Z

src/styles/typography.scss

@@ -1,3 +1,5 @@
+@use 'variables';


Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 8, column 8 of file:///Users/denis/Documents/superhero-wallet/src/styles/typography.scss:8:8:
Sass @ import rules are deprecated and will be removed in Dart Sass 3.0.0.
More info and automated migrator: https://sass-lang.com/d/import

davidyuk · 2024-12-26T13:41:41Z

tests/e2e/integration/deeplinks.cy.js

@@ -4,7 +4,7 @@ import { STUB_ACCOUNT, STUB_TX_BASE_64 } from '@/constants/stubs';

 const callbackUrl = encodeURIComponent('http://localhost');
 const encodedContractCallTx = encodeURIComponent('tx_+HQrAaEBbLQV9y00r/WCZ4XWrEVDpdiLPiLx2282rdKA1dkRTlmCA7yhBWuJbvnfcBIKpR/IbC+ywuM9P7fvmDFNerFKykCB+M1qA4al2v8FcAAAhzcV8VZnVACDGBf4hDuaygCQKxEV1igBG2+HI4byb8D/wPOLADU=');
-const encodedGaAttachTx = encodeURIComponent('tx_+O1QAaEByqPFadmQk4sGtyDiquosAZyKJNmherKOhheVIEYTLCITuIv4iUYDoIMndi6iAoqQltixF/3A6WlN0+rWVAan4LvFLy2pEJlhwLhcuDv+RNZEHwA3ADcAGg6CPwEDP/5s8lcLADcCFwcXdwAIPAIE+wNNTm90IGluIEF1dGggY29udGV4dAEBAJsvAhFE1kQfEWluaXQRbPJXCyVhdXRob3JpemWCLwCFNy4xLjAAoGzyVwsKFZm3CCkeUKo9rxPQx/JIS8M33a0kE6N/1KAJgwcAA4ZIjzqPaAAATIQ7msoAhysRRNZEHz+4yEN3');
+const encodedUnknownTx = encodeURIComponent('tx_+FKB/wGhAcqjxWnZkJOLBrcg4qrqLAGciiTZoXqyjoYXlSBGEywioQHKo8Vp2ZCTiwa3IOKq6iwBnIok2aF6so6GF5UgRhMsIguGDyb1YcgAABOAFw87cw==');


For this test better to choose a completely broken transaction, to ensure that the wallet is forward-compatible.

The problem I had with GaAttachTx is that currently, sdk rejects building such transactions with non-1 nonce.

nonce should be equal 1 if GaAttachTx, got 19 instead

currently it will fail only if I request to replace the signer

davidyuk · 2024-12-26T13:46:00Z

src/protocols/aeternity/libs/AeternityAdapter.ts

  Tag,
 } from '@aeternity/aepp-sdk';
+import { getHdWalletAccountFromSeed } from '@aeternity/aepp-sdk-13';


I will make a new release of sdk to fix that. Meanwhile, you can use it as is since tree shaking will remove the unused code.

CedrikNikita · 2025-01-13T07:55:39Z

tests/e2e/support/coingecko-stubs.js

@@ -0,0 +1,203 @@
+beforeEach(() => {


It was done here aa852fa .
Isn't it working properly?

github-actions · 2025-01-16T16:55:39Z

Deployed to feature-update-sdk.wallet.z52da5wt.xyz, artifacts

github-actions · 2025-01-17T19:50:06Z

Deployed to feature-update-sdk.wallet.z52da5wt.xyz, artifacts

github-actions · 2025-01-24T14:09:08Z

Deployed to feature-update-sdk.wallet.z52da5wt.xyz, artifacts

github-actions · 2025-01-24T14:27:34Z

Deployed to feature-update-sdk.wallet.z52da5wt.xyz, artifacts

CedrikNikita · 2025-02-07T05:51:27Z

src/content-scripts/inject.ts

@@ -100,8 +101,7 @@ const runContentScript = () => {
    if (document.readyState === 'complete') {
      clearInterval(readyStateCheckInterval);
      const port = browser.runtime.connect();
-      // @ts-expect-error
-      const extConnection = new BrowserRuntimeConnection({ port });
+      const extConnection = new BrowserRuntimeConnection({ port, debug: false });


Can you explain this change? What is pros/cons of this?

This is actually a bug on sdk side that I'll fix in 14.1.0: debug shouldn't be required. From your side @ts-expect-error is an overkill because it can ignore a more significant TS error, its usage should be limited.

dvdbak · 2025-02-13T08:52:05Z

Build URL is open in a black screen. Not able to test.

github-actions · 2025-02-13T19:28:49Z

Deployed to feature-update-sdk.wallet.z52da5wt.xyz, artifacts

dvdbak · 2025-02-14T11:40:28Z

It is not possible to import an AE account via private key.
Tryied with: 2602a31e7a3ce342a6f287ee10164cadb88fd16eaa883bd9b93a75f653be03322594d09b5907f8a6f1a9fd2c7e5b067720fe78d862e83b9d6a7ef0f0fb3173f2

dvdbak · 2025-02-14T11:51:08Z

Unable to create a Gift card. created gift card has 0 value.
on Mainnet and Testnet

Nagrywanie.ekranu.2025-02-14.124655.mp4

encodedUnknownTx is a spend tx with a tag replaced to 0xff

> Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

davidyuk · 2025-02-18T23:34:36Z

I fixed the above two bugs, also

added ability to add account by sk_-encoded private key, like sk_HjvV4utY9bQGZtp4vJ4mexCUjAoBcSW1mMT9Y9q4S6UYSqiqB
improved useStorageRef types to fix warning

Invalid prop: type check failed for prop "secretKey". Expected Buffer, got Object  at <InviteItem>
at <IonContent>
at <IonPage>
at <Invite>

github-actions · 2025-02-18T23:37:58Z

Deployed to feature-update-sdk.wallet.z52da5wt.xyz, artifacts

CedrikNikita · 2025-02-19T04:56:55Z

src/composables/storageRef.ts

      if (restoredValue !== null) {
-        await setStorageState(restoredValue);


I think setStorageState here was used in case we would want to introduce serializer to an existing (stored) value,

dvdbak · 2025-02-19T15:10:22Z

#3498 Able to import twice the same account via sk_ prefixed key
@CedrikNikita Will it be handle by the Wallet?

github-actions · 2025-02-19T18:18:41Z

Deployed to feature-update-sdk.wallet.z52da5wt.xyz, artifacts

davidyuk · 2025-02-19T19:07:00Z

I've reverted the ability to import sk_-encoded private key, will do it separately

dvdbak · 2025-02-21T12:02:12Z

LGTM

davidyuk requested a review from CedrikNikita December 26, 2024 13:33

davidyuk commented Dec 26, 2024

View reviewed changes

CedrikNikita reviewed Jan 13, 2025

View reviewed changes

davidyuk mentioned this pull request Jan 16, 2025

AccountMnemonicFactory: init by seed and sync methods aeternity/aepp-sdk-js#2038

Merged

davidyuk force-pushed the feature/update-sdk branch from fff2f7f to e6c440b Compare January 16, 2025 16:47

davidyuk force-pushed the feature/update-sdk branch from e6c440b to 08f62ea Compare January 17, 2025 19:37

CedrikNikita approved these changes Jan 24, 2025

View reviewed changes

davidyuk force-pushed the feature/update-sdk branch from 7f7c658 to 3a6b13a Compare January 24, 2025 14:17

CedrikNikita reviewed Feb 7, 2025

View reviewed changes

davidyuk force-pushed the feature/update-sdk branch 2 times, most recently from 1994413 to 91e8cb5 Compare February 13, 2025 19:19

CedrikNikita linked an issue Feb 18, 2025 that may be closed by this pull request

Update to sdk 14.x.x #3350

Closed

davidyuk added 9 commits February 19, 2025 00:14

refactor: avoid importing aesdk internals

939c4ba

refactor: use NodeJS.Timeout instead NodeJS.Timer everywhere

b2381cf

chore: put the same license to package.json as in LICENSE file

f681ad7

chore(deps): update sdk to 14.0.0

ad4429f

refactor: use ts-expect-error instead ts-ignore

6efbbe0

test: fix unknown tx signing

06706e7

encodedUnknownTx is a spend tx with a tag replaced to 0xff

chore(deps): use a maintained bip39 implementation

abfb4a4

refactor: prefer use over import in scss

e783f10

> Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

test: stub requests to coingecko in e2e to avoid rate limit errors

445397e

test: remove old not working coingecko stubs

2c797d0

davidyuk force-pushed the feature/update-sdk branch from 91e8cb5 to 730e35b Compare February 18, 2025 23:29

CedrikNikita reviewed Feb 19, 2025

View reviewed changes

refactor: add serialized type to useStorageRef

0300170

davidyuk force-pushed the feature/update-sdk branch from 730e35b to 0300170 Compare February 19, 2025 18:06

CedrikNikita merged commit feae8b6 into develop Feb 26, 2025
6 checks passed

CedrikNikita deleted the feature/update-sdk branch February 26, 2025 10:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update sdk to 14 and related fixes #3444

Update sdk to 14 and related fixes #3444

davidyuk commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 26, 2024

davidyuk Dec 26, 2024

davidyuk Dec 26, 2024

davidyuk Dec 26, 2024

CedrikNikita Jan 13, 2025

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 17, 2025

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

CedrikNikita Feb 7, 2025

davidyuk Feb 7, 2025 •

edited

Loading

dvdbak commented Feb 13, 2025

github-actions bot commented Feb 13, 2025

dvdbak commented Feb 14, 2025

dvdbak commented Feb 14, 2025

davidyuk commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

CedrikNikita Feb 19, 2025

dvdbak commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

davidyuk commented Feb 19, 2025

dvdbak commented Feb 21, 2025

		if (restoredValue !== null) {
		await setStorageState(restoredValue);

Update sdk to 14 and related fixes #3444

Update sdk to 14 and related fixes #3444

Conversation

davidyuk commented Dec 26, 2024 • edited Loading

github-actions bot commented Dec 26, 2024

davidyuk Dec 26, 2024

Choose a reason for hiding this comment

davidyuk Dec 26, 2024

Choose a reason for hiding this comment

davidyuk Dec 26, 2024

Choose a reason for hiding this comment

CedrikNikita Jan 13, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 16, 2025

github-actions bot commented Jan 17, 2025

github-actions bot commented Jan 24, 2025

github-actions bot commented Jan 24, 2025

CedrikNikita Feb 7, 2025

Choose a reason for hiding this comment

davidyuk Feb 7, 2025 • edited Loading

Choose a reason for hiding this comment

dvdbak commented Feb 13, 2025

github-actions bot commented Feb 13, 2025

dvdbak commented Feb 14, 2025

dvdbak commented Feb 14, 2025

davidyuk commented Feb 18, 2025

github-actions bot commented Feb 18, 2025

CedrikNikita Feb 19, 2025

Choose a reason for hiding this comment

dvdbak commented Feb 19, 2025

github-actions bot commented Feb 19, 2025

davidyuk commented Feb 19, 2025

dvdbak commented Feb 21, 2025

davidyuk commented Dec 26, 2024 •

edited

Loading

davidyuk Feb 7, 2025 •

edited

Loading