Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: automatically set scalafmt version #6024

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

ferrarimarco
Copy link
Collaborator

Automatically append the 'version' configuration parameter to the scalafmt configuration file when building the image instead of using a GitHub Actions workflow to keep the scalafmt configuration file up to date. This makes the building process more reproducible and self-contained in the Dockerfile, and it also avoid stalling Dependabot PRs that update scalafmt because when there are automatically added commits to a PR, they block triggering workflows for that PR.

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I checked that all workflows return a success.
  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER or Close #ISSUE_NUMBER text to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.
  • Add the pull request to a milestone, eventually creating one, that matches
    with the version that release-please proposes in the preview-release-notes CI job.

@ferrarimarco ferrarimarco added infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label labels Aug 14, 2024
@ferrarimarco ferrarimarco added this to the 6.9.0 milestone Aug 14, 2024
@ferrarimarco ferrarimarco force-pushed the auto-scalafmt-version branch from e538a5f to 127761d Compare August 14, 2024 08:44
Automatically append the 'version' configuration parameter to the
scalafmt configuration file when building the image instead of using a
GitHub Actions workflow to keep the scalafmt configuration file up to
date. This makes the building process more reproducible and
self-contained in the Dockerfile, and it also avoid stalling Dependabot
PRs that update scalafmt because when there are automatically added
commits to a PR, they block triggering workflows for that PR.
@ferrarimarco ferrarimarco force-pushed the auto-scalafmt-version branch from 127761d to a77b217 Compare August 14, 2024 08:49
@ferrarimarco ferrarimarco merged commit 38dd638 into main Aug 14, 2024
148 checks passed
@ferrarimarco ferrarimarco deleted the auto-scalafmt-version branch August 14, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure related to project structure and maintenance O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant