Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): list method using wrong encoder #405

Merged
merged 1 commit into from
May 26, 2024

Conversation

florianmari
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the current behavior?

list methods is sending a request to API storage with snake_case instead of lowerCamelCase for SortBy option

What is the new behavior?

Using a regular encoder to send the correct key, so now the key sortBy sent works.

@florianmari florianmari requested a review from grdsdev as a code owner May 25, 2024 21:27
Copy link
Collaborator

@grdsdev grdsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@grdsdev grdsdev merged commit f16989a into supabase:main May 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants