Skip to content

fix: make clippy check work with include_elf! #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

liuchengxu
Copy link
Contributor

Close #2216

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@liuchengxu
Copy link
Contributor Author

@ratankaliani @leruaa Could you please take a look at this PR?

@liuchengxu
Copy link
Contributor Author

Hmm, it seems to be trickier than I thought, still trying to figure it out...

@liuchengxu liuchengxu marked this pull request as draft April 11, 2025 13:39
@liuchengxu liuchengxu marked this pull request as ready for review April 11, 2025 14:35
@liuchengxu
Copy link
Contributor Author

Resort to a more reliable approach: create dummy ELF files when running clippy, please have another look.

@liuchengxu
Copy link
Contributor Author

Ping @leruaa

@leruaa
Copy link
Contributor

leruaa commented Apr 15, 2025

I believe this approach will truncate the ELFs when running cargo clippy if they already exists, and the next cargo run won't regenerate them if the program sources haven't changed.

Closing as I don't see an easy way to do this, thanks anyway for trying!

@leruaa leruaa closed this Apr 15, 2025
@liuchengxu
Copy link
Contributor Author

Hmm, makes sense. Another approach would be introducing a feature clippy, which is supposed to be reliable IMO, but all programs need to annoyingly add this clippy feature to run cargo clippy. I guess I have to disable the clippy check for programs in our project for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make clippy work for sp1
2 participants