Add missing locales/methods for Faker::Name [pt-BR] #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
approved these changes
Oct 10, 2018
| @@ -92,7 +92,40 @@ pt-BR: | |||
| words: [alias, consequatur, aut, perferendis, sit, voluptatem, accusantium, doloremque, aperiam, eaque, ipsa, quae, ab, illo, inventore, veritatis, et, quasi, architecto, beatae, vitae, dicta, sunt, explicabo, aspernatur, aut, odit, aut, fugit, sed, quia, consequuntur, magni, dolores, eos, qui, ratione, voluptatem, sequi, nesciunt, neque, dolorem, ipsum, quia, dolor, sit, amet, consectetur, adipisci, velit, sed, quia, non, numquam, eius, modi, tempora, incidunt, ut, labore, et, dolore, magnam, aliquam, quaerat, voluptatem, ut, enim, ad, minima, veniam, quis, nostrum, exercitationem, ullam, corporis, nemo, enim, ipsam, voluptatem, quia, voluptas, sit, suscipit, laboriosam, nisi, ut, aliquid, ex, ea, commodi, consequatur, quis, autem, vel, eum, iure, reprehenderit, qui, in, ea, voluptate, velit, esse, quam, nihil, molestiae, et, iusto, odio, dignissimos, ducimus, qui, blanditiis, praesentium, laudantium, totam, rem, voluptatum, deleniti, atque, corrupti, quos, dolores, et, quas, molestias, excepturi, sint, occaecati, cupiditate, non, provident, sed, ut, perspiciatis, unde, omnis, iste, natus, error, similique, sunt, in, culpa, qui, officia, deserunt, mollitia, animi, id, est, laborum, et, dolorum, fuga, et, harum, quidem, rerum, facilis, est, et, expedita, distinctio, nam, libero, tempore, cum, soluta, nobis, est, eligendi, optio, cumque, nihil, impedit, quo, porro, quisquam, est, qui, minus, id, quod, maxime, placeat, facere, possimus, omnis, voluptas, assumenda, est, omnis, dolor, repellendus, temporibus, autem, quibusdam, et, aut, consequatur, vel, illum, qui, dolorem, eum, fugiat, quo, voluptas, nulla, pariatur, at, vero, eos, et, accusamus, officiis, debitis, aut, rerum, necessitatibus, saepe, eveniet, ut, et, voluptates, repudiandae, sint, et, molestiae, non, recusandae, itaque, earum, rerum, hic, tenetur, a, sapiente, delectus, ut, aut, reiciendis, voluptatibus, maiores, doloribus, asperiores, repellat] | |||
|
|
|||
| name: | |||
| first_name: ["Alessandro","Alexandre","Alice","Alícia","Aline","Amanda","Ana","Antônio","Arthur","Beatriz","Benício","Benjamin","Bernardo","Bianca","Breno","Bruna","Bryan","Caio","Carla","Carlos","Catarina","Cauã","Cecília","Célia","César","Clara","Dalila","Daniel","Danilo","Davi","Deneval","Djalma","Eduarda","Eduardo","Elísio","Emanuel","Emanuelly","Enrico","Enzo","Esther","Fabiano","Fábio","Fabrícia","Fabrício","Felícia","Feliciano","Felipe","Félix","Fernanda","Francisco","Frederico","Gabriel","Gabriela","Giovanna","Gúbio","Guilherme","Gustavo","Heitor","Helena","Hélio","Heloísa","Henrique","Hugo","Ígor","Isaac","Isabel","Isabela","Isabella","Isabelly","Isadora","Isis","Janaína","Joana","João","Joaquim","Júlia","Júlio","Karla","Kléber","Ladislau","Lara","Larissa","Laura","Lavínia","Leonardo","Letícia","Lívia","Lorena","Lorenzo","Lorraine","Lucas","Lucca","Luiza","Manuela","Marcela","Marcelo","Márcia","Márcio","Marcos","Margarida","Maria","Mariana","Marina","Marli","Matheus","Meire","Melissa","Mércia","Miguel","Morgana","Murilo","Natália","Nataniel","Nicolas","Nicole","Norberto","Núbia","Ofélia","Pablo","Paula","Paulo","Pedro","Pietro","Rafael","Rafaela","Raul","Rebeca","Ricardo","Roberta","Roberto","Salvador","Samuel","Sara","Sarah","Silas","Sílvia","Sirineu","Sophia","Suélen","Talita","Tertuliano","Theo","Thiago","Thomas","Valentina","Vicente","Víctor","Vinicius","Vitor","Vitória","Warley","Washington","Yago","Yango","Yasmin","Yuri","Adriana","Agatha","Alessandra","Allana","Ana Beatriz","Ana Cecília","Ana Clara","Ana Júlia","Ana Laura","Ana Lívia","Ana Luiza","Ana Sophia","Ana Vitória","André","Anthony","Antonella","Antonia","Arthur Gabriel","Arthur Henrique","Arthur Miguel","Augusto","Aurora","Ayla","Bárbara","Bento","Bruno","Calebe","Camila","Carlos Eduardo","Carolina","Clarice","Davi Lucas","Davi Lucas","Davi Lucca","Davi Lucca","Davi Luiz","Davi Miguel","Elisa","Eloah","Emilly","Enzo Gabriel","Enzo Gabriel","Enzo Miguel","Erick","Fernando","Francisca","Gabrielly","Gael","Giulia","Henry","Ian","Igor","Joao","João Gabriel","João Guilherme","João Lucas","João Lucas","João Miguel","João Miguel","João Pedro","João Pedro","João Vitor","João Vitor","José","Juliana","Kaique","Kauê","Laís","Levi","Liz","Louise","Luan","Luana","Lucas Gabriel","Luiz","Luiz Felipe","Luiz Gustavo","Luiz Henrique","Luiz Miguel","Luiz Otávio","Luna","Maitê","Malu","Marcia","Maria Alice","Maria Cecília","Maria Clara","Maria Eduarda","Maria Fernanda","Maria Flor","Maria Helena","Maria Isis","Maria Júlia","Maria Laura","Maria Luiza","Maria Sophia","Maria Valentina","Maria Vitória","Mariah","Mathias","Maya","Milena","Mirella","Nathan","Noah","Oliver","Olívia","Otávio","Patricia","Pedro Henrique","Pedro Henrique","Pedro Lucas","Pedro Miguel","Pérola","Pietra","Rodrigo","Ruan","Ryan","Sophie","Stella","Tiago","Tomás","Vinícius","Vitor Hugo"] | |||
| male_first_name: ["Alessandro","Alexandre","Antônio","Arthur","Benício","Benjamin","Bernardo","Breno","Bryan", | |||
There was a problem hiding this comment.
What about adding the name method just like we did in the English locale?
There was a problem hiding this comment.
Hey, just saw your comment. Sorry, wasn't able to check it earlier.
I agree, and would like to add those methods!
Should I just continue the commits here or create a new PR?
vbrazo
changed the title
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Break first_name into male and female, remove duplicates, and add names * Fix female name on male name left by mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I needed to use the
Faker::Name.male_first_nameandFaker::Name.female_first_name, but they weren't available in pt-BR. So I've updated the locale breaking the first name into male and female names, and the methods now work :)I also found some duplicate male names and changed them to other, unique ones.
Hope this helps to improve the code!