Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Dutch names #1390

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Add more Dutch names #1390

merged 1 commit into from
Oct 10, 2018

Conversation

hisener
Copy link
Contributor

@hisener hisener commented Oct 10, 2018 •
edited by vbrazo
Loading

Fixes #1388

Stephan202
Stephan202 approved these changes Oct 10, 2018
View reviewed changes
Copy link

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment linking to the source of most of these names?

vbrazo
vbrazo approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR and contributing 💯

I don't know Dutch, so please take a look at Stephan's comment and see if it's relevant. In these locale cases, we just trust in the community.

Let me know when it's good to merge.

@hisener
Copy link
Contributor Author

hisener commented Oct 10, 2018

@Stephan202 Sources are also added. Ready to merge?

Stephan202
Stephan202 approved these changes Oct 10, 2018
View reviewed changes
Copy link

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nice! :)

@vbrazo vbrazo merged commit 335f30c into faker-ruby:master Oct 10, 2018
@hisener hisener mentioned this pull request Oct 11, 2018
Merged
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@hisener @vbrazo
Add more Dutch names (faker-ruby#1390)
3626c56
@hisener hisener removed their assignment Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

@vbrazo vbrazo vbrazo approved these changes

Assignees
No one assigned
Labels
🌐 Update Locales
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new Dutch first and last names
3 participants
@hisener @Stephan202 @vbrazo