Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls should ignore test folder #1212

Merged
merged 4 commits into from
May 16, 2018
Merged

Coveralls should ignore test folder #1212

merged 4 commits into from
May 16, 2018

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented May 16, 2018

Coveralls should ignore the test folder. The goal of this PR is to solve this issue.

@vbrazo vbrazo force-pushed the features/add-simplecov branch 2 times, most recently from 29ef300 to c155e04 Compare May 16, 2018 20:54
@vbrazo vbrazo self-assigned this May 16, 2018
@vbrazo vbrazo force-pushed the features/add-simplecov branch 2 times, most recently from ec54121 to 8987b68 Compare May 16, 2018 21:19
@vbrazo vbrazo changed the title Features/add simplecov Coveralls should ignore test folder May 16, 2018
@faker-ruby faker-ruby deleted a comment from coveralls May 16, 2018
@vbrazo vbrazo force-pushed the features/add-simplecov branch 13 times, most recently from 32369db to bdd31f5 Compare May 16, 2018 22:30
@vbrazo vbrazo force-pushed the features/add-simplecov branch 2 times, most recently from 0dea25c to c1b01d6 Compare May 16, 2018 22:38
@vbrazo
Copy link
Member Author

vbrazo commented May 16, 2018

This PR is related to a discussion: #1209

@vbrazo vbrazo force-pushed the features/add-simplecov branch 2 times, most recently from 5c9d690 to 6422926 Compare May 16, 2018 22:54
@vbrazo vbrazo force-pushed the features/add-simplecov branch from 6422926 to 11cd012 Compare May 16, 2018 22:57
repo_token: VJWNNdqvbmV4izRaFRKmXsqNawiDClygs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this token looks terrible, but I don't have access to Travis so I can't create an ENV key. This token provides only-read access, so it should be ok to leave it here for now.

Could you add this key on Travis and let me know? @stympy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know when we could add this ENV key on Travis. I could regenerate it and send you.

@vbrazo vbrazo force-pushed the features/add-simplecov branch 2 times, most recently from 894377b to cd5d3c9 Compare May 16, 2018 23:35
@vbrazo vbrazo force-pushed the features/add-simplecov branch 2 times, most recently from b7094a6 to 8128227 Compare May 16, 2018 23:43
@vbrazo vbrazo force-pushed the features/add-simplecov branch from 8128227 to b2743f5 Compare May 16, 2018 23:46
@vbrazo vbrazo merged commit b83d6f1 into master May 16, 2018
@vbrazo vbrazo deleted the features/add-simplecov branch May 16, 2018 23:53
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant