Add Estonian and Latvian locales #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciej-szlosarczyk
force-pushed
the
add-estonia-and-latvia-locales
branch
from
cc86afa to
9c9f8f9
Compare
maciej-szlosarczyk
force-pushed
the
add-estonia-and-latvia-locales
branch
from
8b1c630 to
c1e3f22
Compare
maciej-szlosarczyk
force-pushed
the
add-estonia-and-latvia-locales
branch
from
c1e3f22 to
1f3d019
Compare
vbrazo
requested changes
May 18, 2018
|
Could you also update the |
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
6394a28 to
d11bd7e
Compare
maciej-szlosarczyk
force-pushed
the
add-estonia-and-latvia-locales
branch
3 times, most recently
from
ed95132 to
a6c49b0
Compare
maciej-szlosarczyk
force-pushed
the
add-estonia-and-latvia-locales
branch
from
a6c49b0 to
4596679
Compare
maciej-szlosarczyk
force-pushed
the
add-estonia-and-latvia-locales
branch
from
4596679 to
8abeeb0
Compare
* Regions * Cities * Names * Phone numbers
maciej-szlosarczyk
force-pushed
the
add-estonia-and-latvia-locales
branch
from
8abeeb0 to
ee1ea90
Compare
|
Hey @vbrazo, now it should be done. |
vbrazo
approved these changes
May 27, 2018
There was a problem hiding this comment.
Well, overall looks good. I've just added a few other tests and now I believe it's good to go.
I saw that you're a first time-contributor. Welcome 🥇 Do not forget to read our contributing doc.
Pretty awesome locales. Let me know if you want to contribute in other modules.
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add missing lorem locale and update changelog * Add Estonian and Latvian fake data: * Regions * Cities * Names * Phone numbers * Add more locale tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently supports: