Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external_account type: should be flexible to accept string or object #879

Closed
alisherk opened this issue Apr 27, 2020 · 4 comments
Closed
Labels

Comments

@alisherk
Copy link

The official stripe documentation mentions external_account accepts token as string and object. Your type expects String only. It should be flexible to accept both types.

` const params: Stripe.AccountCreateParams = {
type: 'custom',
country: data.country,
email: data.email,
requested_capabilities: ['card_payments', 'transfers'],
business_type: data.businessType,
tos_acceptance: {
date: Math.floor(Date.now() / 1000),
ip: context.rawRequest.ip,
},

external_account: {
object: 'bank_account',
account_number: data.bankAccount,

}

}`

@richardm-stripe
Copy link
Contributor

Hi @alisherk, thanks for the report. We're planning on tackling this soon!

@alisherk
Copy link
Author

alisherk commented May 1, 2020

Thank you for the great lib

@dncrews
Copy link

dncrews commented Apr 13, 2021

Any chance of movement on this @richardm-stripe

@richardm-stripe
Copy link
Contributor

Released in v8.145.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants