Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Danger PR review breaking the build #1275

Closed
1 task
shilman opened this issue Jun 14, 2017 · 0 comments
Closed
1 task

Danger PR review breaking the build #1275

shilman opened this issue Jun 14, 2017 · 0 comments
Labels
bug maintenance User-facing maintenance tasks

Comments

@shilman
Copy link
Member

shilman commented Jun 14, 2017

why

Added danger to automate some code review tasks: #1251

However, it currently breaks the build when the PR is issued from a user fork of the repo due to this:

https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

what

  • Disable danger for user forks for now 😭
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shilman