Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

fixes ruby-libstorj #2; related to libstorj #381 #382

Merged

Conversation

bryanchriswhite
Copy link
Contributor

I'm not sure if this fully addresses #381 but it (combined with some ruby) definitely fixes ruby-libstorj's #2

@braydonf
Copy link
Contributor

braydonf commented Aug 19, 2017

We should probably either set the loop to uv_default_loop() or have an option to pass the loop in with storj_init_env.

Having to free something that was created in storj_init_env that storj_destroy_env doesn't free, could lead to it not being freed, especially if loop is set to uv_default_loop().

@bryanchriswhite bryanchriswhite force-pushed the features/uv-loop-refactor branch from 15a985c to 76129c5 Compare August 19, 2017 10:44
@bryanchriswhite
Copy link
Contributor Author

@braydonf like that?

@bryanchriswhite
Copy link
Contributor Author

I hate to be cliche but tests are passing on my machine... What gives?

@bryanchriswhite
Copy link
Contributor Author

nvm... forgot to make before running tests ...facepalm

@braydonf
Copy link
Contributor

braydonf commented Aug 19, 2017

Tested with node-libstorj and it works using uv_default_loop. I think the is just an extra free at free(env->loop); works fine without.

@braydonf braydonf merged commit bd1e4a4 into storj-archived:master Aug 19, 2017
@braydonf
Copy link
Contributor

Merged in bf25e2d

@bryanchriswhite
Copy link
Contributor Author

sweet... thanks :D 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby's has a small RLIMIT_MEMLOCK and LibStorj::Env doesn't unlock atm
2 participants