Reusable function to append suffix parameters

Author: steveukx

simple-git/src/lib/plugins/suffix-paths.plugin.ts

@@ -6,32 +6,30 @@ export function suffixPathsPlugin(): SimpleGitPlugin<'spawn.args'> {
       type: 'spawn.args',
       action(data) {
          const prefix: string[] = [];
-         const suffix: string[] = [];
-         let suffixFound: boolean = false;
+         let suffix: undefined | string[];
+         function append(args: string[]) {
+            (suffix = suffix || []).push(...args);
+         }
 
          for (let i = 0; i < data.length; i++) {
             const param = data[i];
 
             if (isPathSpec(param)) {
-               suffixFound = true;
-               suffix.push(...toPaths(param));
+               append(toPaths(param));
                continue;
             }
 
             if (param === '--') {
-               suffixFound = true;
-               suffix.push(
-                  ...data
-                     .slice(i + 1)
-                     .flatMap((item) => (isPathSpec(item) && toPaths(item)) || item)
+               append(
+                  data.slice(i + 1).flatMap((item) => (isPathSpec(item) && toPaths(item)) || item)
                );
                break;
             }
 
             prefix.push(param);
          }
 
-         return suffixFound ? [...prefix, '--', ...suffix.map(String)] : prefix;
+         return !suffix ? prefix : [...prefix, '--', ...suffix.map(String)];
       },
    };
 }