Feature/preview in floating window #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close the any existing preview because otherwise strange errors happen when the preview is open and the floating window is opened at the same time.
stevearc
requested changes
Jun 6, 2024
|
@PhilippOesch I moved some of the logic around and did some other various refactoring. Take a look, kick the tires, and if you're happy with it I'll merge! |
The refactoring looks good from my view. Thank you for taking your time and looking at it. If you want, you can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I'm a big fan of the floating window, but also of the preview functionality.
This implements #303