Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: reformat-gherkin #633

Closed
1 task done
Drew-Daniels opened this issue Jan 24, 2025 · 0 comments · Fixed by #652
Closed
1 task done

feature request: reformat-gherkin #633

Drew-Daniels opened this issue Jan 24, 2025 · 0 comments · Fixed by #652
Labels
enhancement New feature or request P2 Not a priority. PRs welcome

Comments

@Drew-Daniels
Copy link

Did you check existing requests?

  • I have searched the existing issues

Describe the feature

Thanks so much for making this plugin! I probably use it thousands of times each day for my development workflow. I searched for similar issues to this but didn't find any so I thought I'd make an issue.

I use reformat-gherkin to format .feature files, and it would be nice if conform.nvim had builtin support to format .feature files using this formatter.

Provide background

Here is my conform config:

require("conform").setup({
  format_after_save = function(bufnr)
    local ignore_filetypes = { "norg" }
    if vim.tbl_contains(ignore_filetypes, vim.bo[bufnr].filetype) then
      return
    end
    return { timeout_ms = 500, lsp_format = "fallback" }
  end,
  formatters_by_ft = {
    c = { "clang-format" },
    cucumber = { "reformat-gherkin" },
  },
})

When I try running :Format on a .feature file here is what I see:

Image

When I run :ConformInfo this is the message that was logged:
Image

What is the significance of this feature?

nice to have

Additional details

No response

@Drew-Daniels Drew-Daniels added the enhancement New feature or request label Jan 24, 2025
@stevearc stevearc added the P2 Not a priority. PRs welcome label Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Not a priority. PRs welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants