Skip to content

Commit 08b39a1

Browse files
committed
Fixes #99
1 parent f68c62d commit 08b39a1

File tree

4 files changed

+19
-4
lines changed

4 files changed

+19
-4
lines changed

.npmignore

-1
This file was deleted.

ISSUE_TEMPLATE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ Please provide a reproducible example.
44

55
### If you are submitting a PR
66

7-
As of now, I will not accept PRs without tests. It is hard tot test it manually. And yes tests are not implemented yet - there is a ticket for it.
7+
As of now, I will not accept PRs without tests. It is hard to test it manually. And yes tests are not implemented yet - there is a ticket for it.

Readme.md

+12-2
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,11 @@ Read more about [puppeteer troubleshooting.](https://github.com/GoogleChrome/pup
204204

205205
#### Docker
206206

207-
To run `react-snap` inside docker (especially when using alpine), you might want to use custom chromium executable.
207+
To run `react-snap` inside `docker` (especially when using alpine), you might want to use custom chromium executable. See [#93](https://github.com/stereobooster/react-snap/issues/93#issuecomment-354994505).
208208

209-
For example, use `puppeteerExecutablePath: "/usr/bin/chromium-browser"` you can set chromium executable path to `/usr/bin/chromium-browser`.
209+
```
210+
puppeteerExecutablePath: "/usr/bin/chromium-browser"
211+
```
210212

211213
### Semantic UI
212214

@@ -218,6 +220,14 @@ use the following configuration:
218220
"minifyHtml": { "sortClassName": false }
219221
```
220222

223+
### JSS
224+
225+
> Once JS on the client is loaded, components initialized and your JSS styles are regenerated, it's a good time to remove server-side generated style tag in order to avoid side-effects
226+
>
227+
> https://github.com/cssinjs/jss/blob/master/docs/ssr.md
228+
229+
This is basically mean that JSS doesn't support `rehydration`. See [#99](https://github.com/stereobooster/react-snap/issues/99) for possible solutions.
230+
221231
## Possible improvements
222232

223233
- Improve [preconnect](http://caniuse.com/#feat=link-rel-preconnect), [dns-prefetch](http://caniuse.com/#feat=link-rel-dns-prefetch) functionality, maybe use [media queries](https://developer.mozilla.org/en-US/docs/Web/HTML/Preloading_content). Example: load in small screen - capture all assets, add with a media query for the small screen, load in big screen add the rest of the assets with a media query for the big screen.

package.json

+6
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,12 @@
4242
"bin": {
4343
"react-snap": "./run.js"
4444
},
45+
"files": [
46+
"index.js",
47+
"run.js",
48+
"src/",
49+
"vendor/"
50+
],
4551
"reactSnap": {
4652
"destination": "tmp",
4753
"inlineCss": true,

0 commit comments

Comments
 (0)