Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope annotations must have Runtime Retention #161

Closed
dlemures opened this issue Oct 6, 2016 · 6 comments
Closed

Scope annotations must have Runtime Retention #161

dlemures opened this issue Oct 6, 2016 · 6 comments
Assignees
Milestone

Comments

@dlemures
Copy link
Collaborator

dlemures commented Oct 6, 2016

Scope annotations defined by the user must have Runtime Retention (same as @singleton does).
Otherwise, the runtime checks won't work for those annotation.

Should we force it?
Crash the compiler if any does not have the right retention.

@stephanenicolas
Copy link
Owner

I think it would be a good practice to enforce. Though there is an issue with annotation with runtime retention : all classes using the annotation will be kept in first dex...

@stephanenicolas stephanenicolas added this to the 1.0.1 milestone Oct 6, 2016
@dlemures dlemures modified the milestones: 1.0.4, 1.0.1 Jan 4, 2017
@dlemures dlemures self-assigned this Jan 4, 2017
@stephanenicolas
Copy link
Owner

We should just fail, the first dex would not be impacted much.

@dlemures
Copy link
Collaborator Author

We will fail at compile time if it does not contain the right retention.

@dlemures
Copy link
Collaborator Author

PR: #191

@dlemures
Copy link
Collaborator Author

@dlemures
Copy link
Collaborator Author

PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants