-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope annotations must have Runtime Retention #161
Comments
I think it would be a good practice to enforce. Though there is an issue with annotation with runtime retention : all classes using the annotation will be kept in first dex... |
We should just fail, the first dex would not be impacted much. |
We will fail at compile time if it does not contain the right retention. |
PR: #191 |
PR merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Scope annotations defined by the user must have Runtime Retention (same as @singleton does).
Otherwise, the runtime checks won't work for those annotation.
Should we force it?
Crash the compiler if any does not have the right retention.
The text was updated successfully, but these errors were encountered: