will it support dealloc?

[limboy]

sometimes it's convenient to monitor ViewController's dealloc, i.e. popped from stack, but dealloc is not triggered, so we know there is a memory leak. tried it like this with no luck.

[MyViewController aspect_hookSelector:NSSelectorFromString(@"dealloc") atPosition:AspectPositionBefore withBlock:^(id object, NSArray *arguments) {
    NSLog(@"dealloc:%@", object);
}];

[WayneWeiZhang]

@lzyy dealloc is disabled in aspect_isSelectorHookAllowed method. And as to commit logs, this is due to "workaround #2."

[limboy]

@WayneWeiZhang where is aspect_isSelectorHookAllowed defined? and if the super problem solved, dealloc can be used?

[WayneWeiZhang]

@lzyy Do you have updated your code?

static NSString *const AspectsHasParentToken = @"AspectsHasParentToken";
static BOOL aspect_isSelectorHookAllowed(Class class, SEL selector) {
static NSSet *disallowedSelectorList;
static NSMutableDictionary *swizzledClassesDict;
static dispatch_once_t pred;
dispatch_once(&pred, ^{
swizzledClassesDict = [NSMutableDictionary new];
disallowedSelectorList = [NSSet setWithObjects:@"retain", @"release", @"autorelease", @"dealloc", @"forwardInvocation:", nil];
});

[limboy]

@WayneWeiZhang ha, was looking at the pod version, now see it.

so the reason there is a disallowedSelectorList is because these selectors are managed by ARC, and a bit "magical"?

[WayneWeiZhang]

@lzyy Nope, I think the reason is "Infinite Loop when overriding a method at two points which includes a call to super #2"

[steipete]

Hooking into dealloc is quite a delicate matter. You can't retain the object, and the message forwarding process really isn't suited for that. Also the only usable position would be AspectPositionBefore. It might be possible to add special code paths to work around this, but it wasn't my priority so far. (Blocking is not really related to #2, that was just a coincidence)