Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup multi level dropdown #198

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Followup multi level dropdown #198

merged 2 commits into from
Aug 20, 2024

Conversation

aparlato
Copy link
Collaborator

@aparlato aparlato commented Aug 14, 2024

Description

Previously the multi-level dropdowns were unable to handle large amounts of options and did not scroll. After spending some time overriding the CSS in the sveltestrap dropdowns, I decided it would be best/easiest to create our own dropdown component.

Closes #197

QA steps

  • Confirm that multi-level dropdowns work with large lists of options

Author checklist

Create the PR

  • Fill out PR template
  • N/A Make sure you've added a CHANGELOG entry under "Unreleased"
    • We had yet to release the previous iteration of this
  • Request a review
  • Make any requested changes and get approval

After approval

  • Merge any changes from main into your branch, resolve any conflicts
  • Squash & merge changes into main
  • Delete branch

@aparlato aparlato requested a review from ebrelsford August 14, 2024 20:07
Copy link
Contributor

@ebrelsford ebrelsford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems well to me!

@aparlato aparlato merged commit 980241e into main Aug 20, 2024
@aparlato aparlato deleted the followup-multi-level-dropdown branch August 20, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-level dropdowns are broken for styles with many options
2 participants