Spec - Drop leftover error check (#469)

* Remove leftover err check

* Align argument variable name to type

Author: MatheusFranco99

qbft/decided.go

@@ -64,18 +64,18 @@ func (c *Controller) UponDecided(msg *ProcessingMessage) (*types.SignedSSVMessag
 func ValidateDecided(
 	config IConfig,
 	msg *ProcessingMessage,
-	share *types.CommitteeMember,
+	committeeMember *types.CommitteeMember,
 ) error {
 
-	isDecided, err := IsDecidedMsg(share, msg)
+	isDecided, err := IsDecidedMsg(committeeMember, msg)
 	if err != nil {
 		return err
 	}
 	if !isDecided {
 		return errors.New("not a decided msg")
 	}
 
-	if err := baseCommitValidationVerifySignature(msg, msg.QBFTMessage.Height, share.Committee); err != nil {
+	if err := baseCommitValidationVerifySignature(msg, msg.QBFTMessage.Height, committeeMember.Committee); err != nil {
 		return errors.Wrap(err, "invalid decided msg")
 	}
 
@@ -91,6 +91,6 @@ func ValidateDecided(
 }
 
 // IsDecidedMsg returns true if signed commit has all quorum sigs
-func IsDecidedMsg(share *types.CommitteeMember, msg *ProcessingMessage) (bool, error) {
-	return share.HasQuorum(len(msg.SignedMessage.OperatorIDs)) && msg.QBFTMessage.MsgType == CommitMsgType, nil
+func IsDecidedMsg(committeeMember *types.CommitteeMember, msg *ProcessingMessage) (bool, error) {
+	return committeeMember.HasQuorum(len(msg.SignedMessage.OperatorIDs)) && msg.QBFTMessage.MsgType == CommitMsgType, nil
 }

ssv/committee_runner.go

@@ -149,10 +149,6 @@ func (cr CommitteeRunner) ProcessConsensus(msg *types.SignedSSVMessage) error {
 		SSVMessage:  ssvMsg,
 	}
 
-	if err != nil {
-		return errors.Wrap(err, "could not create SignedSSVMessage from SSVMessage")
-	}
-
 	if err := cr.GetNetwork().Broadcast(ssvMsg.MsgID, msgToBroadcast); err != nil {
 		return errors.Wrap(err, "can't broadcast partial post consensus sig")
 	}