Can't import * from python modules

[sqlalchemy-bot]

Migrated issue, originally created by Anonymous

<%namespace module="myapp.blah" import="*"/>

seems to do dir(myapp.blah), which picks up everything in that module (variables, imported modules), not just functions. It then dies on "util.partial(callable_, ...)" because callable_ isn't callable.

I've hackily fixed it myself in runtime.py:610, not sure if this is a good fix or not:

- if k[0] != '_':
+ if k[0] != '_' and callable(getattr(self.module, k)):

I also tried getting it to look at module.all rather than dir(), but that didn't import anything at all for some reason.

having a good fix upstream would be appreciated :)

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

Well doing dir() is pretty much what one would expect from importing "", unless there's an __all__ present. I'm not a big fan of the "" thing anyway. But yeah I guess since namespace assumes they are callable, we'd need to do pretty much the check you're doing there.

[sqlalchemy-bot]

Anonymous wrote:

For anyone reading who can't modify their current install - Another workaround is to prefix everything that isn't a function with an underscore, like

import somelib as _somelib

_a_module_variable = 42

def foo(context):
    return _somelib.foo() + _a_module_variable

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

3bd802b

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed