This repository was archived by the owner on Feb 23, 2023. It is now read-only.
Refine Spring HATEOAS hints. #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To cover Jackson2 de-/serializer, types annotated with (at) Configuration and those implementing EntityLink.
Use the (at) EnableHypermediaSupport annotation to only register configured media types, their configuration and jackson mappings which saves about 2.5 MB
|
@odrotbohm I potentially merged that one too fast because the CI checks were green, I should have wait your review. If you find something please let @christophstrobl and me know we can refine with additional commits. |
|
Please don't worry too much about me. From what I saw in general this heads in the very right direction and it's even easier to play with for me if it's consumable via snapshots in the first place. I'll have a look at how this works with the RESTBucks sample ASAP. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
HateoasHintsto scan for components that configure certain Hypermedia types such as HAL and UBER instead of maintaining static@TypeHintdeclarations.User code and spring jars will also be scanned for usage of Jackson2 annotations, modules and de-/serializers, registering those as well as all jackson annotations on them.
Custom
RepresentationModels, theirRepresentationModelProcessorand the target domain types are also looked up and registered.An optimization, that extracts the
HypermediaTypefrom@EnableHypermediaSupport(type = {...})and only registers the above mentioned hints for the configured formats, was moved to a separate commit (13d7abb) as we may want to introduce this in a later stage - feel free to drop it.