Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Application not detected as started when spring-aot-maven-plugin is active #740

Closed
ch4mpy opened this issue Apr 18, 2021 · 7 comments
Closed
Labels
type: bug A general bug
Milestone

Comments

@ch4mpy
Copy link

ch4mpy commented Apr 18, 2021

My apps are not detected as started anymore when I add spring-aot-maven-plugin to my pom file.

This has at least to manifestations :

  • spinner never changes to green arrow in Spring Boot Dashboard
  • more annoying : springdoc-openapi-maven-plugin fails my builds as it relies on spring-boot-maven-plugin to start the app at pre-integration-test and waits for the app to be reported as started before fetching OpenAPI spec file.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 18, 2021
@sdeleuze
Copy link
Contributor

Could you please provide a project that would allow us to reproduce this issue?

@sdeleuze sdeleuze added the status: waiting-for-feedback We need additional information before we can continue label Apr 19, 2021
@ch4mpy
Copy link
Author

ch4mpy commented Apr 19, 2021

Here is a repo with minimal project : git@github.com:ch4mpy/spring-native-740.git

Steps to reproduce:

  1. vanilla project from start.spring.io with spring-native and web
  2. click "start" in STS Boot Dashboard => the spinner never turns into green arrow
  3. add start goal to spring-boot-maven-plugin pre-integration-test execution => build fails

All I changed is adding an execution to spring-boot-maven-plugin :

			<plugin>
				<groupId>org.springframework.boot</groupId>
				<artifactId>spring-boot-maven-plugin</artifactId>
				<configuration>
					<image>
						<builder>paketobuildpacks/builder:tiny</builder>
						<env>
							<BP_NATIVE_IMAGE>true</BP_NATIVE_IMAGE>
						</env>
					</image>
				</configuration>
				<executions>
					<execution>
						<id>pre-integration-test</id>
						<goals>
							<goal>start</goal>
						</goals>
					</execution>
				</executions>
			</plugin>

Build fails because of undetected start when spring-aot-maven-plugin is there, only (reason for ticket title).

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 19, 2021
@sdeleuze
Copy link
Contributor

sdeleuze commented May 3, 2021

Maybe related to the fact we disable MBeans for footprint reasons, since I see a Failed to connect to MBean server at port 9001 message when running mvn pre-integration-test.

@ch4mpy
Copy link
Author

ch4mpy commented May 4, 2021

How can I enable it ?

Setting following properties in application.properties does not improve the situation :

spring.jmx.enabled=true
server.tomcat.mbeanregistry.enabled=true

@sdeleuze
Copy link
Contributor

@ch4mpy Could you set removeJmxSupport = false on Spring AOT plugin side and let me know how it goes? Maybe we could infer its configuration from spring.jmx.enabled one, not sure yet.

@sdeleuze sdeleuze added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels May 11, 2021
@spring-projects-issues
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label May 18, 2021
@sdeleuze sdeleuze added type: bug A general bug and removed status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged or decided on labels May 18, 2021
@sdeleuze sdeleuze added this to the 0.10.0 milestone May 18, 2021
@sdeleuze
Copy link
Contributor

Should be solved by cc87cf5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A general bug
Development

No branches or pull requests

3 participants