Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Add preliminary Spring Batch support #203

Closed
dsyer opened this issue Jul 14, 2020 · 10 comments
Closed

Add preliminary Spring Batch support #203

dsyer opened this issue Jul 14, 2020 · 10 comments
Assignees
Labels
type: compatibility Native image compatibility issue
Milestone

Comments

@dsyer
Copy link
Contributor

dsyer commented Jul 14, 2020

The Batch samples look like they are using generated JSON. It would be nice to tighten that up.

@aclement
Copy link
Contributor

Yes, I don't think it was pulled back into hints, I was just relieved when it was working. We should do that.

@aclement aclement added this to the v0.8.0 milestone Jul 16, 2020
@sdeleuze sdeleuze modified the milestones: v0.8.0, v0.9.0 Jul 27, 2020
@sdeleuze sdeleuze modified the milestones: v0.9.0, v0.8.0 Aug 14, 2020
@sdeleuze
Copy link
Contributor

sdeleuze commented Aug 14, 2020

@aclement I am not sure we can properly support Batch in 0.8 yet, I have tried to polish a little bit the build config and I get this error message:

org.springframework.beans.factory.BeanDefinitionStoreException: @Configuration classes need to be marked as proxyBeanMethods=false. Found: [org.springframework.batch.core.configuration.annotation.ScopeConfiguration, org.springframework.batch.core.configuration.annotation.SimpleBatchConfiguration]

If this is confirmed I think I would be in favor of moving Batch support with proper hints to 0.9.

@mminella Could you please update Batch to use proxyBeanMethods=false?

@sdeleuze sdeleuze modified the milestones: v0.8.0, v0.9.0 Aug 14, 2020
@sdeleuze sdeleuze changed the title Work out why only Batch sample needs so much reflection configuration Add proper support for Batch Aug 14, 2020
@sdeleuze sdeleuze modified the milestones: v0.9.0, v0.8.2 Aug 30, 2020
dsyer pushed a commit to scratches/spring-graalvm-native that referenced this issue Sep 23, 2020
dsyer pushed a commit to scratches/spring-graalvm-native that referenced this issue Sep 23, 2020
@sdeleuze sdeleuze changed the title Add proper support for Batch Add Spring Batch support Nov 3, 2020
@sdeleuze sdeleuze added the type: compatibility Native image compatibility issue label Jan 8, 2021
@sdeleuze sdeleuze assigned mminella and unassigned aclement Jan 12, 2021
@mminella
Copy link
Contributor

Depends on #459

@sdeleuze
Copy link
Contributor

@mminella @aclement FYI batch is now using the build-time infrastructure like other samples, and to make it work I had to specify this native hint.

Since 0.9.0 is getting closer and #459 does not look like a trivial change, I would like to propose to postpone both #459 and batch support to 0.9.1 is order to allow us to focus our time and energy on polishing bti on what is currently supported, and to mature properly batch support before announcing it. Any thoughts?

@mminella
Copy link
Contributor

@sdeleuze I have no objections as batch support is currently blocked on #459.

@mminella
Copy link
Contributor

@sdeleuze Why would that hint be added there and not to BatchHints?

@sdeleuze
Copy link
Contributor

@mminella It was temporary since I was not sure if it was Batch specific or not, but I can indeed move it to BatchHints.

After discussion with @aclement, we agreed that #459 and more generally batch support will require more work, so it is more reasonsable to move it to 0.9.1.

@sdeleuze sdeleuze modified the milestones: 0.9.0, 0.9.1 Feb 16, 2021
sdeleuze added a commit that referenced this issue Feb 16, 2021
@sdeleuze sdeleuze modified the milestones: 0.9.1, 0.9.2 Feb 26, 2021
@sdeleuze sdeleuze modified the milestones: 0.11.0, 0.10.0 Mar 15, 2021
@sdeleuze
Copy link
Contributor

As discussed in #667 (comment), among other things, the batch sample build.sh should be updated to avoid passing custom arguments in order to ensure the build is easily reproducible.

@sdeleuze sdeleuze modified the milestones: 0.10.0, 0.11.0 May 18, 2021
@sdeleuze sdeleuze modified the milestones: 0.11.0, 0.12.0 Jul 20, 2021
@sdeleuze sdeleuze modified the milestones: 0.12.0, 0.11.0 Aug 25, 2021
@sdeleuze sdeleuze modified the milestones: 0.11.0-M1, 0.11.x Sep 24, 2021
@snicoll
Copy link
Contributor

snicoll commented Nov 25, 2021

@sdeleuze looking at the history of this issue, I am not sure what is remaining.

@sdeleuze sdeleuze self-assigned this Nov 30, 2021
@sdeleuze
Copy link
Contributor

batch sample is fine, batch-io is not since it is still using JSON configuration file. I will try to turn that to general batch hints, and add application specific hints to the application class which already contains an @AotProxyHint here.

That should allow us to claim preliminary support.

@sdeleuze sdeleuze changed the title Add Spring Batch support Add preliminary Spring Batch support Nov 30, 2021
sdeleuze added a commit that referenced this issue Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: compatibility Native image compatibility issue
Development

No branches or pull requests

5 participants