Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Please add a @TypeHint for JwtDecoder.class for Spring Security's hints #1377

Closed
joshlong opened this issue Dec 14, 2021 · 2 comments · Fixed by #1379
Closed

Please add a @TypeHint for JwtDecoder.class for Spring Security's hints #1377

joshlong opened this issue Dec 14, 2021 · 2 comments · Fixed by #1379
Assignees
@eleftherias
Labels
type: compatibility Native image compatibility issue
Milestone
0.11.1

Comments

@joshlong
Copy link
Contributor

joshlong commented Dec 14, 2021 •
edited
Loading

The class is used reflectively in the bowels of Spring Security's OAuth / OIDC support and will stop the build from proceeding.

see okta-samples/okta-spring-boot-sample#27 for an example

cc @mraible
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 14, 2021
@sdeleuze sdeleuze added this to the 0.11.1 milestone Dec 14, 2021
@sdeleuze sdeleuze added type: compatibility Native image compatibility issue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 14, 2021
@sdeleuze
Copy link
Contributor

@eleftherias Could you please take care of this one?

Since non-annotation triggers now leverage static analysis capabilities, maybe something like @NativeHint(trigger = JwtDecoder.class, types = @TypeHint(types = JwtDecoder.class)) will be enough. That said, worth to test it and analyze why it is needed.

@eleftherias
Copy link
Contributor

I see the issue, looking into the best way to fix it now.

eleftherias added a commit to eleftherias/spring-native that referenced this issue Dec 14, 2021
@eleftherias
Fix Security OAuth2 Client OIDC
8e511de 
Closes spring-atticgh-1377
@eleftherias eleftherias mentioned this issue Dec 14, 2021
Merged
sdeleuze pushed a commit that referenced this issue Dec 16, 2021
@eleftherias @sdeleuze
Fix Security OAuth2 Client OIDC
5464922 
Closes gh-1377
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eleftherias eleftherias

Labels
type: compatibility Native image compatibility issue
Milestone
0.11.1
Development

Successfully merging a pull request may close this issue.

Fix Security OAuth2 Client OIDC eleftherias/spring-native
4 participants
@joshlong @sdeleuze @eleftherias @spring-projects-issues