Adding two methods with the same name lead to duplicated method names in generated code

[ViniciusArnhold]

Hi, while trying to compile a project which uses Playtika/feign-reactive with spring-native 0.11.0-SNAPSHOT we've been hitting the following compilation error:

> Task :reactive-feign-app:compileAotMainJava
/home/runner/work/spring-native-experiments/spring-native-experiments/reactive-feign-app/build/generated/sources/aotMain/reactivefeign/spring/config/ContextBootstrapInitializer.java:23: error: method registerReactiveFeignClientSpecification(GenericApplicationContext) is already defined in class ContextBootstrapInitializer
  public static void registerReactiveFeignClientSpecification(GenericApplicationContext context) {
                     ^

build action log

reactivefeign/spring/config/ContextBootstrapInitializer.java contents

public final class ContextBootstrapInitializer {
  public static void registerReactiveFeignClientSpecification(GenericApplicationContext context) {
    BeanDefinitionRegistrar.of("default.dev.viniciusarnhold.experiments.aot.app.ReactiveFeignApplication.ReactiveFeignClientSpecification", ReactiveFeignClientSpecification.class).withConstructor(String.class, Class[].class)
        .instanceSupplier((instanceContext) -> instanceContext.create(context, (attributes) -> new ReactiveFeignClientSpecification(attributes.get(0), attributes.get(1)))).customize((bd) -> {
      ConstructorArgumentValues argumentValues = bd.getConstructorArgumentValues();
      argumentValues.addIndexedArgumentValue(0, "default.dev.viniciusarnhold.experiments.aot.app.ReactiveFeignApplication");
      argumentValues.addIndexedArgumentValue(1, new String[] {  });
    }).register(context);
  }

  public static void registerReactiveFeignClientSpecification(GenericApplicationContext context) {
    BeanDefinitionRegistrar.of("github.ReactiveFeignClientSpecification", ReactiveFeignClientSpecification.class).withConstructor(String.class, Class[].class)
        .instanceSupplier((instanceContext) -> instanceContext.create(context, (attributes) -> new ReactiveFeignClientSpecification(attributes.get(0), attributes.get(1)))).customize((bd) -> {
      ConstructorArgumentValues argumentValues = bd.getConstructorArgumentValues();
      argumentValues.addIndexedArgumentValue(0, "github");
      argumentValues.addIndexedArgumentValue(1, new Class[] {  });
    }).register(context);
  }

  public static void registerReactiveFeignClientFactoryBean(GenericApplicationContext context) {
    BeanDefinitionRegistrar.of("dev.viniciusarnhold.experiments.aot.app.client.GithubClient", ReactiveFeignClientFactoryBean.class)
        .instanceSupplier(ReactiveFeignClientFactoryBean::new).customize((bd) -> {
      bd.setPrimary(true);
      MutablePropertyValues propertyValues = bd.getPropertyValues();
      propertyValues.addPropertyValue("url", "");
      propertyValues.addPropertyValue("path", "");
      propertyValues.addPropertyValue("name", "github");
      propertyValues.addPropertyValue("type", "dev.viniciusarnhold.experiments.aot.app.client.GithubClient");
      propertyValues.addPropertyValue("decode404", false);
      propertyValues.addPropertyValue("fallback", void.class);
      propertyValues.addPropertyValue("fallbackFactory", void.class);
    }).register(context);
  }

  public static void registerReactiveFeignAutoConfiguration(GenericApplicationContext context) {
    BeanDefinitionRegistrar.of("reactivefeign.spring.config.ReactiveFeignAutoConfiguration", ReactiveFeignAutoConfiguration.class)
        .instanceSupplier((instanceContext) -> {
          ReactiveFeignAutoConfiguration bean = new ReactiveFeignAutoConfiguration();
          instanceContext.field("configurations", List.class)
              .resolve(context, false).ifResolved((attributes) -> {
                Field configurationsField = ReflectionUtils.findField(ReactiveFeignAutoConfiguration.class, "configurations", List.class);
                ReflectionUtils.makeAccessible(configurationsField);
                ReflectionUtils.setField(configurationsField, bean, attributes.get(0));
              });
              return bean;
            }).register(context);
      }
    }

It started to occur sometime after 0.11.0-M2 (in M2 we have an infinite recursion on ConfigurationProperties with java.lang.Class attributes, which has been fixed in HEAD)

Is this an expected problem which has to be fixed in reactive-feign, or a problem in spring-native?
Apart from this problem, spring-native has been working great for us!

How to reproduce

• git clone https://github.com/ViniciusArnhold/spring-native-experiments.git
• cd spring-native-experiments
• ./gradlew :reactive-feign-app:build

[snicoll]

@ViniciusArnhold thanks for the report. I doubt feign would work in its current form as it creates a child context at runtime that isn't supported by Spring AOT.

Apart from this problem, spring-native has been working great for us!

Do you mean your sample worked with 0.11.0.M1 ?

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[ViniciusArnhold]

I doubt feign would work in its current form as it creates a child context at runtime that isn't supported by Spring AOT.

Ok, thanks for the explanation.

Do you mean your sample worked with 0.11.0.M1 ?

I meant the usage of other spring projects, such as spring-data, this specific sample never worked.

[snicoll]

Thanks for the follow up. Let's see if we can do something about the duplicate still. We might also support child context at some point.

[snicoll]

@ViniciusArnhold I've repurposed this issue to focus on the duplication. The sample should build now but feign won't work until we add support for that. Thanks for the sample!