Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Please add type hints for Reactor's Traces class #1098

Closed
joshlong opened this issue Sep 29, 2021 · 2 comments
Closed

Please add type hints for Reactor's Traces class #1098

joshlong opened this issue Sep 29, 2021 · 2 comments
Assignees
@sdeleuze
Labels
type: compatibility Native image compatibility issue
Milestone
0.11.0-M1

Comments

@joshlong
Copy link
Contributor

Reactor's Traces reflectively instantiates three types in its Traces class which breaks in a native context. Please register hints for them. I'll file an issue asking them to please kindly consider changing those to .class literals insted of strings, for the future. I think that should fix things, right?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 29, 2021
@sdeleuze sdeleuze self-assigned this Sep 30, 2021
@sdeleuze sdeleuze added type: compatibility Native image compatibility issue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 30, 2021
@sdeleuze sdeleuze added this to the 0.11.0-M1 milestone Sep 30, 2021
@sdeleuze
Copy link
Contributor

Done, please let me know if that does not work as expected. I don't think changing to .class would be enough since that will only bring access to the class not the constructor.

We are working on better inlining when constants are used with GraalVM team, that could help. For now those hints are good enough IMO.

@sdeleuze sdeleuze mentioned this issue Sep 30, 2021
Closed
@joshlong
Copy link
Contributor Author

thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sdeleuze sdeleuze

Labels
type: compatibility Native image compatibility issue
Milestone
0.11.0-M1
Development

No branches or pull requests
3 participants
@joshlong @sdeleuze @spring-projects-issues