Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Unable to detect constructor with multiple matches #1035

Closed
snicoll opened this issue Sep 16, 2021 · 1 comment
Closed

Unable to detect constructor with multiple matches #1035

snicoll opened this issue Sep 16, 2021 · 1 comment
Assignees
Labels
type: bug A general bug
Milestone

Comments

@snicoll
Copy link
Contributor

snicoll commented Sep 16, 2021

IsNewAwareAuditingHandler has two constructors (one being deprecated).

The bean definition has a value for the parameter but the value is an inner bean definition so if we want to improve the algorithm, we'll have to inspect the value. It probably would be better to throw an exception rather than taking the first constructor and hope for the best.

@snicoll snicoll added type: bug A general bug theme: aot labels Sep 16, 2021
@snicoll snicoll added this to the 0.11.0 milestone Sep 16, 2021
@snicoll snicoll self-assigned this Sep 16, 2021
snicoll added a commit that referenced this issue Sep 16, 2021
This commit uses the resolved parameter types, including detection of
inner bean definition, rather than query ConstructorArgumentValues if
it can process a given type. The latter will transparently convert the
value if necessary, leading to detecting a constructor that will not
ultimately match.

Closes gh-1035
@snicoll
Copy link
Contributor Author

snicoll commented Sep 16, 2021

Fixed by f64f445

@snicoll snicoll closed this as completed Sep 16, 2021
snicoll added a commit that referenced this issue Sep 28, 2021
This commit uses the resolved parameter types, including detection of
inner bean definition, rather than query ConstructorArgumentValues if
it can process a given type. The latter will transparently convert the
value if necessary, leading to detecting a constructor that will not
ultimately match.

Closes gh-1035
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A general bug
Development

No branches or pull requests

1 participant