Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Handle @PersistenceContext in reflection metadata #998

Closed
snicoll opened this issue Aug 26, 2021 · 2 comments
Closed

Handle @PersistenceContext in reflection metadata #998

snicoll opened this issue Aug 26, 2021 · 2 comments
Labels
status: duplicate A duplicate of another issue type: task A general task

Comments

@snicoll
Copy link
Contributor

snicoll commented Aug 26, 2021

Consider the following:

https://github.com/spring-projects-experimental/spring-native/blob/76da6837d0a9db3d009b634c739ffb1700e65f11/samples/hibernate/src/main/java/app/main/SampleApplication.java#L22-L29

On the JVM (with AOT) the field is injected because the jvm sees the PersistenceContext annotation. It does not on native because no reflection config exists for it. We could fix this by adding a dedicated class that scans and add the reflection metadata. We don't really have an SPI around this now so it would be worth creating one.

@snicoll snicoll added the type: task A general task label Aug 26, 2021
@snicoll snicoll added this to the 0.11.0 milestone Aug 26, 2021
@sdeleuze sdeleuze self-assigned this Sep 24, 2021
@sdeleuze
Copy link
Contributor

sdeleuze commented Oct 1, 2021

This is currently handled by PersistentContextMarkedComponentProcessor and migrating this should be part of the wider effort to port ComponentProcessor to the new AOT engine, so moving it to 0.11.x.

@sdeleuze sdeleuze modified the milestones: 0.11.0-M1, 0.11.x Oct 1, 2021
@snicoll
Copy link
Contributor Author

snicoll commented Nov 25, 2021

I believe this one is now a duplicate of #1297. Please reopen if I have misunderstood.

@snicoll snicoll closed this as completed Nov 25, 2021
@snicoll snicoll removed this from the 0.11.0 milestone Nov 25, 2021
@snicoll snicoll added the status: duplicate A duplicate of another issue label Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: duplicate A duplicate of another issue type: task A general task
Development

No branches or pull requests

2 participants