Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Commit 0677044

Browse files
committed
Try to auto discover health indicator
1 parent ddda646 commit 0677044

File tree

5 files changed

+100
-51
lines changed

5 files changed

+100
-51
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
package org.springframework.boot.actuate.endpoint.annotation;
2+
3+
import org.springframework.aot.context.bootstrap.generator.infrastructure.nativex.BeanFactoryNativeConfigurationProcessor;
4+
import org.springframework.aot.context.bootstrap.generator.infrastructure.nativex.NativeConfigurationRegistry;
5+
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
6+
import org.springframework.boot.actuate.health.HealthContributor;
7+
import org.springframework.boot.actuate.health.HealthIndicator;
8+
import org.springframework.nativex.hint.Flag;
9+
import org.springframework.util.ClassUtils;
10+
11+
/**
12+
* A {@link BeanFactoryNativeConfigurationProcessor} that register reflection access for
13+
* actuator health contributor.
14+
*
15+
* @author Olivier Boudet
16+
*/
17+
public class HealthIndicatorNativeConfigurationProcessor implements BeanFactoryNativeConfigurationProcessor {
18+
@Override
19+
public void process(ConfigurableListableBeanFactory beanFactory, NativeConfigurationRegistry registry) {
20+
System.err.println("HealthIndicatorNativeConfigurationProcessor");
21+
if (ClassUtils.isPresent("org.springframework.boot.actuate.health.HealthIndicator", beanFactory.getBeanClassLoader())) {
22+
String[] healthIndicatorBeanNames = beanFactory.getBeanNamesForType(HealthIndicator.class);
23+
System.err.println(healthIndicatorBeanNames.length);
24+
for (String bean : healthIndicatorBeanNames) {
25+
System.err.println(bean);
26+
registry.reflection().forType(beanFactory.getBean(bean, HealthIndicator.class).getClass()).withFlags(Flag.allDeclaredConstructors).build();
27+
}
28+
}
29+
}
30+
}

spring-aot/src/main/resources/META-INF/spring.factories

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ org.springframework.aot.context.bootstrap.generator.bean.DefaultBeanRegistration
1212

1313
org.springframework.aot.context.bootstrap.generator.infrastructure.nativex.BeanFactoryNativeConfigurationProcessor=\
1414
org.springframework.boot.actuate.endpoint.annotation.EndpointNativeConfigurationProcessor,\
15+
org.springframework.boot.actuate.endpoint.annotation.HealthIndicatorNativeConfigurationProcessor,\
1516
org.springframework.boot.context.properties.ConfigurationPropertiesNativeConfigurationProcessor,\
1617
org.springframework.data.RepositoryDefinitionConfigurationProcessor
1718

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
/*
2+
* Copyright 2019-2021 the original author or authors.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
package org.springframework.boot.actuate.endpoint.annotation;
18+
19+
import org.junit.jupiter.api.Test;
20+
import org.springframework.aot.context.bootstrap.generator.infrastructure.nativex.NativeConfigurationRegistry;
21+
import org.springframework.aot.context.bootstrap.generator.infrastructure.nativex.NativeReflectionEntry;
22+
import org.springframework.beans.factory.support.BeanDefinitionBuilder;
23+
import org.springframework.beans.factory.support.DefaultListableBeanFactory;
24+
import org.springframework.boot.actuate.health.Health;
25+
import org.springframework.boot.actuate.health.HealthContributor;
26+
import org.springframework.boot.actuate.health.HealthIndicator;
27+
import org.springframework.nativex.hint.Flag;
28+
29+
import java.util.List;
30+
31+
import static org.assertj.core.api.Assertions.assertThat;
32+
33+
/**
34+
* Tests for {@link HealthIndicatorNativeConfigurationProcessor}.
35+
*
36+
* @author Olivier Boudet
37+
*/
38+
class HealthIndicatorNativeConfigurationProcessorTests {
39+
40+
@Test
41+
void registerHealthIndicator() {
42+
DefaultListableBeanFactory beanFactory = new DefaultListableBeanFactory();
43+
beanFactory.registerBeanDefinition("noise", BeanDefinitionBuilder.rootBeanDefinition(String.class).getBeanDefinition());
44+
beanFactory.registerBeanDefinition("healthIndicator", BeanDefinitionBuilder.rootBeanDefinition(TestHealthIndicator.class).getBeanDefinition());
45+
NativeConfigurationRegistry registry = process(beanFactory);
46+
List<NativeReflectionEntry> entries = registry.reflection().getEntries();
47+
assertThat(entries).anySatisfy((entry) -> {
48+
assertThat(entry.getType()).isEqualTo(TestHealthIndicator.class);
49+
assertThat(entry.getFlags()).contains(Flag.allDeclaredConstructors);
50+
});
51+
assertThat(entries).hasSize(1);
52+
}
53+
54+
private NativeConfigurationRegistry process(DefaultListableBeanFactory beanFactory) {
55+
NativeConfigurationRegistry registry = new NativeConfigurationRegistry();
56+
new HealthIndicatorNativeConfigurationProcessor().process(beanFactory, registry);
57+
return registry;
58+
}
59+
60+
@SuppressWarnings("unused")
61+
static class TestHealthIndicator implements HealthIndicator {
62+
63+
@Override
64+
public Health health() {
65+
return Health.up().build();
66+
}
67+
}
68+
69+
}

spring-native-configuration/src/main/java/org/springframework/boot/actuate/autoconfigure/health/HealthContributorHints.java

-50
This file was deleted.

spring-native-configuration/src/main/resources/META-INF/services/org.springframework.nativex.type.NativeConfiguration

-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ org.springframework.boot.actuate.autoconfigure.endpoint.web.servlet.WebMvcEndpoi
3737
org.springframework.boot.actuate.autoconfigure.endpoint.web.reactive.WebFluxEndpointManagementContextConfigurationHints
3838
org.springframework.boot.actuate.autoconfigure.env.EnvironmentEndpointAutoConfigurationHints
3939
org.springframework.boot.actuate.autoconfigure.health.HealthEndpointAutoConfigurationHints
40-
org.springframework.boot.actuate.autoconfigure.health.HealthContributorHints
4140
org.springframework.boot.actuate.autoconfigure.info.InfoEndpointAutoConfigurationHints
4241
org.springframework.boot.actuate.autoconfigure.jolokia.JolokiaEndpointAutoConfigurationHints
4342
org.springframework.boot.actuate.autoconfigure.metrics.MetricsEndpointAutoConfigurationHints

0 commit comments

Comments
 (0)