Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lambdaStages): Exporting Lambda stages based on the feature flag setting #10085

Merged
merged 3 commits into from
Apr 25, 2024
Merged

fix(lambdaStages): Exporting Lambda stages based on the feature flag setting #10085

merged 3 commits into from
Apr 25, 2024

Conversation

christosarvanitis
Copy link
Member

When the Lambda Stages where backported from the plugin to Deck the register pipeline stages where not exported.

Also the NumberConcurrencyInput.tsx from the plugin is a duplicate of the NumberInput of Deck so removing it from the codebase

@christosarvanitis christosarvanitis marked this pull request as ready for review April 24, 2024 15:02
jasonmcintosh
jasonmcintosh approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as comfortable with UI pieces, but this LOOKS like should fix the lambda issue

@christosarvanitis
Copy link
Member Author

@mattgogerly would love your input on this since you did all the heavy lifting on the Lambda import :)

@jasonmcintosh jasonmcintosh added the ready to merge Reviewed and ready for merge label Apr 25, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Apr 25, 2024
@mergify mergify bot merged commit 93bab65 into spinnaker:master Apr 25, 2024
4 checks passed
@jasonmcintosh
Copy link
Member

https://github.com/Mergifyio backport release-1.34.x release-1.33.x release-1.32.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 25, 2024 •
edited
Loading

backport release-1.34.x release-1.33.x release-1.32.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 25, 2024
@christosarvanitis @mergify
fix(lambdaStages): Exporting Lambda stages based on the feature flag …
2067e2d 
…settings (#10085)

Co-authored-by: Jason <jason.mcintosh@armory.io>
Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com>
(cherry picked from commit 93bab65)
mergify bot pushed a commit that referenced this pull request Apr 25, 2024
@christosarvanitis @mergify
fix(lambdaStages): Exporting Lambda stages based on the feature flag …
fa31133 
…settings (#10085)

Co-authored-by: Jason <jason.mcintosh@armory.io>
Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com>
(cherry picked from commit 93bab65)
mergify bot pushed a commit that referenced this pull request Apr 25, 2024
@christosarvanitis @mergify
fix(lambdaStages): Exporting Lambda stages based on the feature flag …
2a5d9e8 
…settings (#10085)

Co-authored-by: Jason <jason.mcintosh@armory.io>
Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com>
(cherry picked from commit 93bab65)
This was referenced Apr 25, 2024
Merged
Merged
Merged
mergify bot added a commit that referenced this pull request Apr 25, 2024
@mergify @christosarvanitis
fix(lambdaStages): Exporting Lambda stages based on the feature flag …
f88b118 
…settings (#10085) (#10090)

Co-authored-by: Jason <jason.mcintosh@armory.io>
Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com>
(cherry picked from commit 93bab65)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
mergify bot added a commit that referenced this pull request Apr 25, 2024
@mergify @christosarvanitis
fix(lambdaStages): Exporting Lambda stages based on the feature flag …
abd95bd 
…settings (#10085) (#10092)

Co-authored-by: Jason <jason.mcintosh@armory.io>
Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com>
(cherry picked from commit 93bab65)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
mergify bot added a commit that referenced this pull request Apr 25, 2024
@mergify @christosarvanitis
fix(lambdaStages): Exporting Lambda stages based on the feature flag …
102b439 
…settings (#10085) (#10091)

Co-authored-by: Jason <jason.mcintosh@armory.io>
Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com>
(cherry picked from commit 93bab65)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
@christosarvanitis christosarvanitis mentioned this pull request Jun 7, 2024
Merged
This was referenced Jun 10, 2024
Merged
Merged
Merged
sahititarigoppula pushed a commit to OpsMx/deck-oes that referenced this pull request Jul 2, 2024
@mergify @christosarvanitis @sahititarigoppula
fix(lambdaStages): Exporting Lambda stages based on the feature flag …
f660a02 
…settings (spinnaker#10085) (spinnaker#10091)

Co-authored-by: Jason <jason.mcintosh@armory.io>
Co-authored-by: ovidiupopa07 <105648914+ovidiupopa07@users.noreply.github.com>
(cherry picked from commit 93bab65)

Co-authored-by: Christos Arvanitis <christos.arvanitis@armory.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmcintosh jasonmcintosh jasonmcintosh approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.35
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christosarvanitis @jasonmcintosh @spinnakerbot @ovidiupopa07