Deprecate redundant linting

[danieleades]

removes deprecated linting.

note that this is missing one lint - E704. I feel like it's overkill keeping an entire flake8 toolchain around for just one lint.
Especially since that lint has been comprehensively disabled inline with noqas

[danieleades]

perhaps i should remove all of the noqa: f704s? i'll add another separate commit with those removed and we can discuss

[AA-Turner]

Would the current Ruff settings raise the flake8 failure from #11791 (comment)? I'll try and find some other recent examples where flake8 failed but Ruff didn't.

A

[danieleades]

Would the current Ruff settings raise the flake8 failure from #11791 (comment)? I'll try and find some other recent examples where flake8 failed but Ruff didn't.

A

it should. From memory that was just a formatting issue related to some indents. In principle, the E* lints should pick that up, right?

If only there was some kind of tool, perhaps built into ruff, that would automatically resolve issues with formatting and indentation ;)

[AA-Turner]

Can we keep the 'external' entry and the inline E704 suppressions? I'd be happier to merge then.

A

[danieleades]

Can we keep the 'external' entry and the inline E704 suppressions? I'd be happier to merge then.

A

the external entry doesn't seem to be required any more. Perhaps as a result of the adding and subsequent removing of E704 from ruff?

[AA-Turner]

Having looked a little closer, see:

• Implement remaining pycodestyle rules astral-sh/ruff#2402
• E124 / E125 / E128 / E129 / E303: Mentioned by pycodestyle but not ruff astral-sh/ruff#4666

There are several rules that flake8 does implement that Ruff simply doesn't, and we aren't at a point where we'll adopt an automatic formatter. So I think I'm happy to drop flake8-simplify, but we still need to keep flake8 proper, it seems.

A

[AA-Turner]

See #11906