Fix body data contents #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
Jul 31, 2024
| $isJson = str_contains($contentType, '/json') || str_contains($contentType, '+json'); | ||
|
|
||
| if ($isJson) { | ||
| return new InputBag((array) json_decode($this->request->getContent(), true)); |
There was a problem hiding this comment.
Maybe break this up in a couple of separate statements to improve readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we only took a look for the request data body context to what was passed as $_POST variables. While when the content type is JSON we want to look at the PHP input stream.
This PR follows the same mechanism as a Laravel request.
And also fixes some issues with the snapshot testing.