Dockerization via fabric8 plugin

[vtelensky]

• Basic dockerization via fabric8 plugin

[sparkoo]

what is purpose of src/main/resources/boxes/f25/f25_1_virtualbox.box file? I don't like it.

[sparkoo]

could you please extract all version string to variables https://github.com/sparkoo/boxitory/blob/devel/pom.xml#L66

[vtelensky]

Done

[sparkoo]

Is it all and working? I would welcome some doc as I'd like to try it myself :)

[vtelensky]

I have created very minimalistic configuration of docker image. Please see README.md and try to run it. It will need some more upgrades to be more configurable similarly as via application.properties. I will create different task for that.

[vtelensky]

I have added ability to read application.properties file and use server.port value for exposing container port the same as it is setup in properties file. Setting up application behaviour via properties file is a bit tricky for containerized apps. It should be done differently eg. via environment vars specified by --env param of docker command. Env vars are lately passed to some shell script which is starting app via jar file. It is usual way in those kind of scenarios. We can discuss later on some beer.

[sparkoo]

What is intended usage of docker image? I'd like to build an image and the run it instead of running java -jar .... I've accomplished that with building an image with mvn clean package docker:build as you've wrote to doc. Then I've ran the image with mount volume like this docker run --rm -p 8083:8083 -v $( echo $PWD ):/home/boxitory boxitory having application.properties and boxes in $PWD.
Is this how it should be used?

[sparkoo]

If ^^^ is intended usage, I'm satisfied with that. It just needs to be documented.
I can see one remaining issue here. In container, boxitory gives me path inside the container in response, e.g. sftp://some@server:/home/boxitory/boxes/f28/f28_1_vbox.box, /home/boxitory being path inside the container. The path exists just inside the container and if I request that url from another machine, it of course does not work. Do you have any solution how to solve this?

[vtelensky]

What is intended usage of docker image? I'd like to build an image and the run it instead of running java -jar .... I've accomplished that with building an image with mvn clean package docker:build as you've wrote to doc. Then I've ran the image with mount volume like this docker run --rm -p 8083:8083 -v $( echo $PWD ):/home/boxitory boxitory having application.properties and boxes in $PWD.
Is this how it should be used?

There are several ways how to use it. The way which you have explained is also possible. The thing is that by your way you are running image directly via docker command and you are utilize mvn plugin fabric8 only for building the image. By running mvn docker:run plugin runs docker command with exception that there are preconfigured parameter for -p and -v. We should discuss what would be the intended way of running docker image. I think usage of fabric8 decouples users from knowledge of Docker.

[vtelensky]

If ^^^ is intended usage, I'm satisfied with that. It just needs to be documented.
I can see one remaining issue here. In container, boxitory gives me path inside the container in response, e.g. sftp://some@server:/home/boxitory/boxes/f28/f28_1_vbox.box, /home/boxitory being path inside the container. The path exists just inside the container and if I request that url from another machine, it of course does not work. Do you have any solution how to solve this?

I have setup that the host path to boxes and container path to boxes are the same. For the time being I've set it up as /tmp/boxes. Can be changed. Try to run in via mvn plugin and we can discuss how to resolve this.

[sparkoo]

I'm not sure about latest changes. I would reduce requirements to two cases:

• run container with maven plugin. I'm happy with boxes at .boxes/ dir here as this should be ran just in dev phase and it can be overwritten by dev easily.
• build image and run container. Here we need 3 things to get in/out of container. Boxes dir, application.properties and logs.
  ** boxes can stay in /home/boxitory/boxes inside container and you have to bind the volume -v /boxes/at/host:/home/boxitory/boxes
  ** application.properties should be also easily injectable with -v /path/to/application.properties:/home/boxitory/application.properties
  ** logs should be also easily doable by -v /host/logs:/home/boxitory/logs

[sparkoo]

Build is not failing at my local neither. Travis complains about logs dir. Shouldn't this line be without /logs? Same as on line 218 where also isn't /boxes directory.

[sparkoo]

I've run build locally and it built docker image when just doing mvn clean install. I'd like to build docker image with extra command, not by default.

[vtelensky]

I've disabled fabric8 plugin executions during all the maven phases. You can still use the plugin by commands I've documented.

[sparkoo]

thaanks! created boxitory image on dockerhub https://cloud.docker.com/u/sparkoo/repository/docker/sparkoo/boxitory 🐳