Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-440] Refactor E2E #16

Merged
merged 19 commits into from
Jun 7, 2024
Merged

[SC-440] Refactor E2E #16

merged 19 commits into from
Jun 7, 2024

Conversation

hexonaut
Copy link
Contributor

Refactoring the E2E cross-domain testing to be generalized. In particular:

  • Split out Bridging from Domains - Domain = blockchain (IE Ethereum, Optimism, Solana, etc), Bridge = Optimism Native Bridge, Circle CCTP, etc
  • Don't assume anchoring on Ethereum
  • Drop the L1/L2 language it should just be source and destination domains

@hexonaut hexonaut requested review from barrutko and lucas-manuel May 20, 2024 08:08
@hexonaut hexonaut self-assigned this May 20, 2024
@hexonaut hexonaut changed the base branch from master to SC-425-cctp-support May 20, 2024 08:09
Base automatically changed from SC-425-cctp-support to master May 20, 2024 09:10
@hexonaut hexonaut marked this pull request as ready for review May 29, 2024 21:34
Copy link
Contributor

@lucas-manuel lucas-manuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely want to see @barrutko's review on this but this looks good to me as is, I reviewed:

  • Testing file diffs (minor changes)
  • DomainHelpers
  • Bridge

Then I diffed src/test/bridges/* against their *Domain.sol counterparts that were removed as part of this PR. Changes all made sense to me and tests all pass so LGTM after this small change.

Copy link

github-actions bot commented Jun 5, 2024

Coverage after merging SC-440-refactor-e2e into master will be

70.45%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ArbitrumReceiver.sol80%100%75%75%15
   CCTPReceiver.sol96%90%100%100%43
   GnosisReceiver.sol77.78%100%75%62.50%24–26
   OptimismReceiver.sol84.62%100%75%80%21
   XChainForwarders.sol50%100%50%50%122, 139, 169, 186, 198, 241, 70, 83

@hexonaut hexonaut merged commit 26f8b54 into master Jun 7, 2024
2 of 3 checks passed
@hexonaut hexonaut deleted the SC-440-refactor-e2e branch June 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants