-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SC-440] Refactor E2E #16
Conversation
… from the domains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely want to see @barrutko's review on this but this looks good to me as is, I reviewed:
- Testing file diffs (minor changes)
- DomainHelpers
- Bridge
Then I diffed src/test/bridges/* against their *Domain.sol counterparts that were removed as part of this PR. Changes all made sense to me and tests all pass so LGTM after this small change.
Coverage after merging SC-440-refactor-e2e into master will be
Coverage Report
|
Refactoring the E2E cross-domain testing to be generalized. In particular: