Skip to content

Commit d6e9c7e

Browse files
committed
fix: return 404 status code when route isn't found
1 parent ef65920 commit d6e9c7e

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

integration_tests/test_status_code.py

+6
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,12 @@ def test_404_post_request_status_code(session):
1313
assert r.status_code == 404
1414

1515

16+
def test_404_not_found(session):
17+
r = requests.get(f"{BASE_URL}/actually_not_found_route")
18+
assert r.status_code == 404
19+
assert r.text == "Not found"
20+
21+
1622
def test_307_get_request(session):
1723
r = requests.get(f"{BASE_URL}/redirect")
1824
assert r.text == "This is the redirected route"

src/server.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,8 @@ async fn index(
385385
}
386386
}
387387
} else {
388-
response_builder.finish()
388+
response_builder.status(StatusCode::NOT_FOUND);
389+
response_builder.body("Not found")
389390
};
390391

391392
apply_middleware(

0 commit comments

Comments
 (0)