Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drizzlepac/HAP: add more alignment logic to the readthedocs #1944

Open
stscijgbot-hstdp opened this issue Jan 28, 2025 · 1 comment
Open

Comments

@stscijgbot-hstdp
Copy link
Collaborator

stscijgbot-hstdp commented Jan 28, 2025

Issue HLA-1425 was created on JIRA by Steve Goldman:

The code for how a WCS solution is chosen isn't well documented in the readthedocs documentation. It would be good to add more information in a new section, or perhaps here

For example, how the consistency checks work. How a radial_offset_check may result in a fit_quality of 2, and a better WCS solution than a fit solution with an RMS >10 mas.

Another example is how a solution with the minumum number of matches (-2) may be a better solution than a alignment solution with an RMS >10 mas. 

Documentation of where the nmatches are set, and what the different variables refer to would also be good to include. 

Also make it clear how the code picks an SVM reference image. 

@stscijgbot-hstdp
Copy link
Collaborator Author

Comment by Steve Goldman on JIRA:

The selection of the SVM reference image is done in tweakwcs. It looks like the code uses one of the two images that it determines to have the largest overlap in a list of images (unless order is specified by a user). This code is in tweakwcs.imalign.align_wcs().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant